refactor(media_control_element): avoid listener leaks after destroy o…

…ne component
joaopaulovieira · Apr 27, 2021 · 80ad4ae · 80ad4ae
1 parent bee3027
commit 80ad4ae
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/base/media_control_component/media_control_component.js b/src/base/media_control_component/media_control_component.js
@@ -15,12 +15,14 @@ export default class MediaControlComponentPlugin extends UICorePlugin {
 
   constructor(core) {
     super(core)
-    this.$el[0].addEventListener('click', e => { e.stopPropagation() })
+    this._stopPropagation = e => { e.stopPropagation() }
+    this.$el[0].addEventListener('click', this._stopPropagation)
     this.$el[0].classList.add('media-control__elements')
   }
 
   destroy() {
     this._mediaControl = null
+    this.$el[0].removeEventListener('click', this._stopPropagation)
     super.destroy()
   }