PR: Add a button to delete input weather datafiles from the interface #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the button is enabled only when a station is selected in the combobox. - Added a "reload"argument to the method "load_data_dir_content" to better control whether we force a reload of the data or we simply load from the binary.
|
Hello @jnsebgosselin! Thanks for updating the PR.
Comment last updated on November 24, 2017 at 23:23 Hours UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve Issue #91
It happens often that more than one input (concatenated) weather datafile is created for a same climate station. This happens for example if concatenated files are created for a same station, but for different period of time. Currently, to delete an input weather datafile, the user has to do it manually.
The objective of this PR is to add a button in the
Gapfill Weathertab that will allow to delete an input weather datafile directly from GWHAT. This will also be less confusing for new users that maybe do not understand where the data are saved in GWHAT.