PR: Make about what icon visible again #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went with custom signals instead of using an eventfilter.
|
Hello @jnsebgosselin! Thanks for updating the PR.
Comment last updated on September 27, 2017 at 15:52 Hours UTC |
It was messing big time with the layout of the main application.
|
Changes Unknown when pulling a3217b1 on about-what-icon-not-visible into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PyQt5, it seems like it was not possible to move the About WHAT button outside of the visible rectangle of the tab bar. To fix this issue, all the logic related to this button was moved to a new subclass of
QTabWidget.