Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update About GWHAT dialog content and improve the layout #425

Merged
merged 11 commits into from
Jul 19, 2022
Merged

PR: Update About GWHAT dialog content and improve the layout #425

merged 11 commits into from
Jul 19, 2022

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Jul 19, 2022 •
edited
Loading

image

@jnsebgosselin jnsebgosselin added this to the gwhat-0.5.1 milestone Jul 19, 2022
@pep8speaks
Copy link

pep8speaks commented Jul 19, 2022 •
edited
Loading

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 89:80: E501 line too long (81 > 79 characters)
Line 93:80: E501 line too long (80 > 79 characters)

Comment last updated at 2022-07-19 22:18:34 UTC

@jnsebgosselin
Copy link
Owner Author

I finally decided to split the content of the About window in two tabs.

image

@jnsebgosselin jnsebgosselin merged commit 9947e6e into master Jul 19, 2022
@jnsebgosselin jnsebgosselin deleted the update_about_gwhat branch July 20, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: Main type: enhancement type: maintenance
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks