Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update well name when importing a water dataset #417

Closed
wants to merge 1 commit into from
Closed

PR: Update well name when importing a water dataset #417

wants to merge 1 commit into from

Conversation

ayoubc
Copy link
Contributor

@ayoubc ayoubc commented Apr 13, 2022 •
edited by jnsebgosselin
Loading

Fixes #416

@jnsebgosselin
Copy link
Owner

Thank you very much for your contribution!

The test failing does not seem related to your changes. I will review your PR and merge your changes in master in the following days, as soon as possible.

@ayoubc
Copy link
Contributor Author

ayoubc commented Apr 14, 2022

Thank you very much for your contribution!

The test failing does not seem related to your changes. I will review your PR and merge your changes in master in the following days, as soon as possible.

You are welcome ! I was actually investigating about the error showed from tests, it was something related to PyInstaller (conflicts with pip version), but I'm not sure how to solve it. there is some threads talking about it here

@jnsebgosselin jnsebgosselin added this to the gwhat-0.5.1 milestone Jun 21, 2022
@jnsebgosselin jnsebgosselin changed the title Bug fix: update Well name when importing a water dataset PR: Update well name when importing a water dataset Jun 21, 2022
@jnsebgosselin jnsebgosselin mentioned this pull request Jun 21, 2022
Merged
@jnsebgosselin
Copy link
Owner

Hey @ayoubc , just letting you know that I've finally get to integrate your proposed changes in GWHAT. I did it in another PR because I wanted to add CI tests, but I've taken care to preserve your commits in the process so that your contribution gets acknowledged.

Thank you very much again for your contribution. You are the first external contributor to the GWHAT project, this is pretty exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

Well name is not update when importing a water level dataset
2 participants
@ayoubc @jnsebgosselin