Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migrate code to calculate the MRC to the new calc tool api #406

Merged
merged 43 commits into from
Mar 5, 2022
Merged

PR: Migrate code to calculate the MRC to the new calc tool api #406

merged 43 commits into from
Mar 5, 2022

Conversation

jnsebgosselin
Copy link
Owner

The idea is to completely decouple the code to calculate the MRC from WLCalc by migrating the code to the new api defined in WLCalcTool.

This is making WLCalc so much cleaner and will def. reduce the cost of maintenance and of adding new features in the future.

@jnsebgosselin
Move recession module within hydrocalc module
9d2d476
@jnsebgosselin
Add a new MasterRecessionCalcTool to the recession module
cc266c5
@jnsebgosselin
Move _setup_mrc_tool to MasterRecessionCalcTool
8540645
@jnsebgosselin
Move add_mrcperiod to MasterRecessionCalcTool
bea840b
@jnsebgosselin
Move method to draw the mrc to MasterRecessionCalcTool
a074a14
@jnsebgosselin
Move show_mrc_results to MasterRecessionCalcTool
c3b9eb4
@jnsebgosselin
WLCalc: emir signal when wldset is set
50d3b24
@jnsebgosselin
MasterRecessionCalcTool: connect sig_wldset_changed to _on_wldset_cha…
d4b5e67 
…nged method
@jnsebgosselin
Register navigation and select tools
6471d87
@jnsebgosselin
Setup the mrc selector
a880c38
@jnsebgosselin
Add load_mrc_from_wldset method
8e2af0e
@jnsebgosselin
Install MRC tool in WLCalc
a59262f
@jnsebgosselin
Complete MRC tool installation
c9490f6
@jnsebgosselin
WLCalc: remove is_all_btn_raised
c0cc443 
This method is not used anywhere
@jnsebgosselin
Create a new WLCalcVSpanHighlighter
c5dde7d
@jnsebgosselin
Move all MRC logic to MasterRecessionCalcTool
e0ff853
@jnsebgosselin
Rename a file
6a0b1fd
@jnsebgosselin
Add a clear API for WLCalcAxesWidget
79bbaa7
@jnsebgosselin
Move save_mrc_tofile to MasterRecessionCalcTool
21c5ae6
@jnsebgosselin
Update imports
d1541c1
@jnsebgosselin
Change wlcalc tools installation order
b8270da
@jnsebgosselin
Fix draw mrc when date format changes
d0a5d78
@jnsebgosselin
Rename btn_MRCalc -> btn_calc_mrc
3661067
@jnsebgosselin
Rename _btn_MRCalc_isClicked -> calculate_mrc
3115ced
@jnsebgosselin
Move calculate_mrc and fix save_mrc_tofile
44e6c78
@jnsebgosselin
Update test_hydrocalc
c63548d
@jnsebgosselin
WLCalc: fix xycoord draw
d2e6858
@jnsebgosselin
WLCalcAxesWidgetBase: set active to False in init
456432c
@jnsebgosselin
Fix remove mrc axes widget activation
c768176
@jnsebgosselin
Rename btn_addpeak -> btn_add_period
2572f27
@jnsebgosselin jnsebgosselin added this to the gwhat-0.5.1 milestone Mar 4, 2022
@jnsebgosselin jnsebgosselin self-assigned this Mar 4, 2022
@jnsebgosselin jnsebgosselin merged commit 5355fcd into master Mar 5, 2022
@jnsebgosselin jnsebgosselin deleted the refactor_mrc_calc_tool branch March 5, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Analyse Hydrograph component: Master Recession Curve type: techdebt
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsebgosselin