Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Rename WLDataFrame to WLDataset and WLDataset to WLDataFrame #404

Merged
merged 14 commits into from
Mar 2, 2022

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Mar 2, 2022

This totally makes sense, is more coherent with the project manager public methods and it also makes code easier to understand.

@pep8speaks
Copy link

pep8speaks commented Mar 2, 2022

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 23:1: E402 module level import not at top of file

Line 27:1: E402 module level import not at top of file

Comment last updated at 2022-03-02 14:58:41 UTC

@jnsebgosselin jnsebgosselin changed the title PR: Rename WLDataFrame to WLDataset and WLDataset to WLData PR: Rename WLDataFrame to WLDataset and WLDataset to WLDataFrame Mar 2, 2022
@jnsebgosselin jnsebgosselin self-assigned this Mar 2, 2022
@jnsebgosselin jnsebgosselin added this to the gwhat-0.5.1 milestone Mar 2, 2022
@jnsebgosselin jnsebgosselin merged commit 5f843be into master Mar 2, 2022
@jnsebgosselin jnsebgosselin deleted the refactor_wldataset branch March 2, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants