Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add goodness-of-fit stats to MRC exported file and show MRC summary results on startup. #400

Merged
merged 14 commits into from
Feb 22, 2022
Merged

PR: Add goodness-of-fit stats to MRC exported file and show MRC summary results on startup. #400

merged 14 commits into from
Feb 22, 2022

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Feb 22, 2022 •
edited
Loading

  • When opening GWHAT, if a MRC exists for the last opened water level dataset, the information related to the MRC are now automatically shown in the "MRC" tab. It is not necessary to click on "Compute MRC" again.

image

Goodness-of-fit statistics are now exported to the CSV file when saving MRC results to file.

image

@jnsebgosselin
Move goodness-of-fit calculation to the "math" module
eda49c5
@jnsebgosselin
Simplify calculate_mrc code
28715f3
@jnsebgosselin
Update A and B values
298caf4 
This is explained by the conditions to select data for each periods tha
changed slightly.
@jnsebgosselin
test_calc_mrc: assert the number of nonnann in hp
b4e76be
@jnsebgosselin
WLDataFrameHDF5: rename arg peak_indx to periods in "set_mrc"
11483b1 
This will be more consistent with the rest of the code and less
confusing
@jnsebgosselin
Minor codestyle changes
0c7c3f0
@jnsebgosselin
WLDataFrameHDF5: save goodness-of-fit values in project
3844ddd
@jnsebgosselin
Add goodness-of-fit values to exported MRC csv file
40851ed
@jnsebgosselin
Improve MRC export csv file format
c5dfdfb
@jnsebgosselin
WLCalc: show stored MRC results if any in the GUI when loading a project
f1142b6
@jnsebgosselin
Add test_project_backward_compatibility
8710c3e
@jnsebgosselin
Expand test_project_backward_compatibility
acfcb80
@pep8speaks
Copy link

pep8speaks commented Feb 22, 2022 •
edited
Loading

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:1: E402 module level import not at top of file
Line 22:1: E402 module level import not at top of file

Comment last updated at 2022-02-22 18:41:18 UTC

@jnsebgosselin jnsebgosselin self-assigned this Feb 22, 2022
@jnsebgosselin jnsebgosselin merged commit bdbd628 into master Feb 22, 2022
@jnsebgosselin jnsebgosselin deleted the impvrove_mrc_outputs branch February 22, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Master Recession Curve type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks