PR: upgrade numpy and pyqt versions #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numpy version 1.19.x series is now quite stable. The 1.16.* series is quite old and has not received any update since December 29, 2019. This is going to be a problem when we decide to upgrade the version of Python.
The last update of pyqt for the 5.12 series was version 5.12.3 that was released on June 26, 2019. This is a problem if we want to upgrade to Python 3.8, since this version of Python was first release on October 10, 2019.
The 5.15 series is now almost 1 year old and has now received 4 bug fix releases. We can assume it is now quite stable, so I guess it is relatively safe to upgrade the pyqt version that we use to package gwire to the latest release of the 5.15 series.