Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve xticks and xtick labels plotting in hydrographs #351

Merged
merged 8 commits into from
Nov 11, 2020

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Nov 11, 2020

In my opinion, the way the xtick labels are currently aligned with the xticks is confusing, i.e. the top left corner of the labels is aligned with the middle position between the major tick marks.

Also, I think that using major xticks and enabling vertical grid for xticks that do not have a label make the graph too dense.

So this PR introduce the following changes to address the aforementioned issues:

  • Aligned xtick label with the major xticks.
  • Use minor ticks when there is no label.
  • Don't use vertical grid for minor xticks.

image

For comparison, this is what the xticks and xtick labels look like before this PR.

image

@jnsebgosselin jnsebgosselin merged commit eea2b39 into master Nov 11, 2020
@jnsebgosselin jnsebgosselin deleted the improve_xticks_labels_hydrographs branch November 11, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant