Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Improve read weather datafiles and fix reading file with no missing data #339

Merged
merged 22 commits into from
Oct 3, 2020
Merged

PR: Improve read weather datafiles and fix reading file with no missing data #339

merged 22 commits into from
Oct 3, 2020

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Oct 2, 2020 •
edited
Loading

Fixes #338

  • Improved the reading of input data to make use of pandas higher functions.
  • Expanded the tests and simplified the test files.

@pep8speaks
Copy link

pep8speaks commented Oct 2, 2020 •
edited
Loading

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-03 18:05:41 UTC

@jnsebgosselin jnsebgosselin merged commit 7ead892 into master Oct 3, 2020
@jnsebgosselin jnsebgosselin deleted the fix_read_weather_datafiles branch October 3, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to import weather dataset if there is no missing values in the dataset
2 participants
@jnsebgosselin @pep8speaks