Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Expand tests for the project selector #309

Merged
merged 2 commits into from
Sep 11, 2020
Merged

PR: Expand tests for the project selector #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8844b49
Asser len of selector menu
jnsebgosselin Aug 28, 2020
2bb3bcb
Assert menu len in test_project
jnsebgosselin Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions gwhat/projet/tests/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ def test_create_new_projet(projmanager, mocker, projectpath):
assert projmanager.project_selector.text() == NAME + '.gwt'
assert projmanager.project_selector.recent_projects() == [
projectpath]
assert len(projmanager.project_selector.menu.actions()) == 4

# Close the project.
projmanager.close_projet()
Expand All @@ -139,6 +140,7 @@ def test_load_projet(projmanager, mocker, projectfile):
assert projmanager.project_selector.text() == NAME + '.gwt'
assert projmanager.project_selector.recent_projects() == [
projectfile]
assert len(projmanager.project_selector.menu.actions()) == 4

projmanager.close_projet()

Expand All @@ -157,6 +159,7 @@ def test_load_non_existing_project(projmanager, mocker, projectpath):
assert projmanager.projet is None
assert projmanager.project_selector.text() == ''
assert projmanager.project_selector.recent_projects() == []
assert len(projmanager.project_selector.menu.actions()) == 3


def test_load_invalid_project(projmanager, mocker, projectpath):
Expand All @@ -178,6 +181,7 @@ def test_load_invalid_project(projmanager, mocker, projectpath):
assert projmanager.projet is None
assert projmanager.project_selector.text() == ''
assert projmanager.project_selector.recent_projects() == []
assert len(projmanager.project_selector.menu.actions()) == 3


def test_load_corrupt_project_continue(projmanager, mocker, projectfile):
Expand Down Expand Up @@ -206,6 +210,7 @@ def test_load_corrupt_project_continue(projmanager, mocker, projectfile):
assert projmanager.project_selector.text() == NAME + '.gwt'
assert projmanager.project_selector.recent_projects() == [
projectfile]
assert len(projmanager.project_selector.menu.actions()) == 4

# Backup file are not generated when the project is corrupt.
assert not osp.exists(projectfile + '.bak')
Expand All @@ -232,6 +237,7 @@ def test_load_corrupt_project_cancel(projmanager, mocker, projectfile):
assert projmanager.projet is None
assert projmanager.project_selector.text() == ''
assert projmanager.project_selector.recent_projects() == []
assert len(projmanager.project_selector.menu.actions()) == 3

# Backup file are not generated when the project is corrupt.
assert not osp.exists(projectfile + '.bak')
Expand All @@ -255,6 +261,7 @@ def test_restore_invalid_project(projmanager, mocker, projectfile, bakfile):
assert projmanager.projet is None
assert projmanager.project_selector.text() == ''
assert projmanager.project_selector.recent_projects() == []
assert len(projmanager.project_selector.menu.actions()) == 3

# Try loading the corrupt project and accept to restore from backup.
mock_qmsgbox.return_value = QMessageBox.Yes
Expand All @@ -270,6 +277,7 @@ def test_restore_invalid_project(projmanager, mocker, projectfile, bakfile):
assert projmanager.project_selector.text() == NAME + '.gwt'
assert projmanager.project_selector.recent_projects() == [
projectfile]
assert len(projmanager.project_selector.menu.actions()) == 4


def test_restore_invalid_project_from_invalid_backup(projmanager, mocker,
Expand All @@ -295,6 +303,7 @@ def test_restore_invalid_project_from_invalid_backup(projmanager, mocker,
assert projmanager.projet is None
assert projmanager.project_selector.text() == ''
assert projmanager.project_selector.recent_projects() == []
assert len(projmanager.project_selector.menu.actions()) == 3


def test_restore_corrupt_project(projmanager, mocker, projectfile, bakfile):
Expand All @@ -316,6 +325,7 @@ def test_restore_corrupt_project(projmanager, mocker, projectfile, bakfile):
assert projmanager.projet is None
assert projmanager.project_selector.text() == ''
assert projmanager.project_selector.recent_projects() == []
assert len(projmanager.project_selector.menu.actions()) == 3

# Try loading the corrupt project and click Ignore.
mock_checkproj.reset_mock()
Expand All @@ -330,6 +340,7 @@ def test_restore_corrupt_project(projmanager, mocker, projectfile, bakfile):
assert projmanager.project_selector.text() == NAME + '.gwt'
assert projmanager.project_selector.recent_projects() == [
projectfile]
assert len(projmanager.project_selector.menu.actions()) == 4

# Try loading the corrupt project and click Yes.
mock_checkproj.reset_mock()
Expand All @@ -344,6 +355,7 @@ def test_restore_corrupt_project(projmanager, mocker, projectfile, bakfile):
assert projmanager.project_selector.text() == NAME + '.gwt'
assert projmanager.project_selector.recent_projects() == [
projectfile]
assert len(projmanager.project_selector.menu.actions()) == 4


if __name__ == "__main__":
Expand Down
12 changes: 12 additions & 0 deletions gwhat/projet/tests/test_project_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def project_selector(qtbot, projectfiles):

assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6
assert project_selector._current_project is None
assert project_selector.text() == ''

Expand Down Expand Up @@ -82,21 +83,25 @@ def test_add_recent_project(project_selector, projectfiles):
project_selector.add_recent_project(None)
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Test adding a project whose file is NOT accessible.
project_selector.add_recent_project(projectfiles[1])
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Test adding a project that is already in the list of recent projects.
project_selector.add_recent_project(projectfiles[2])
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [2, 0, 3]])
assert len(project_selector.menu.actions()) == 6

# Test adding a project that is not in the list of recent projects.
project_selector.add_recent_project(projectfiles[4])
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [4, 2, 0]])
assert len(project_selector.menu.actions()) == 6


def test_remove_recent_project(project_selector, projectfiles):
Expand All @@ -107,21 +112,25 @@ def test_remove_recent_project(project_selector, projectfiles):
project_selector.remove_recent_project(None)
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Test removing a project whose file is NOT accessible.
project_selector.remove_recent_project(projectfiles[1])
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Test removing a project that is NOT in the list of recent projects.
project_selector.remove_recent_project(projectfiles[4])
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Test removing a project that is in the list of recent projects.
project_selector.remove_recent_project(projectfiles[2])
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 3]])
assert len(project_selector.menu.actions()) == 5


def test_delete_recent_project(project_selector, projectfiles, qtbot):
Expand All @@ -134,6 +143,7 @@ def test_delete_recent_project(project_selector, projectfiles, qtbot):
assert len(project_selector.menu.actions()) == 3 + 3
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Try to remove a protected action.
pos = project_selector.menu.actionGeometry(
Expand All @@ -143,6 +153,7 @@ def test_delete_recent_project(project_selector, projectfiles, qtbot):
assert len(project_selector.menu.actions()) == 3 + 3
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 2, 3]])
assert len(project_selector.menu.actions()) == 6

# Try to remove a recent project.
pos = project_selector.menu.actionGeometry(
Expand All @@ -152,6 +163,7 @@ def test_delete_recent_project(project_selector, projectfiles, qtbot):
assert len(project_selector.menu.actions()) == 3 + 2
assert project_selector.recent_projects() == (
[projectfiles[i] for i in [0, 3]])
assert len(project_selector.menu.actions()) == 5

project_selector.menu.close()

Expand Down