Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Ensure backward compatibility with previously saved BRF results #288

Merged
merged 7 commits into from
Apr 17, 2019

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Apr 17, 2019

The goal is to ensure that the new "export to csv or Excel file" feature implemented in PR #287 is working with previously saved BRF results.

Also, this PR improve how the default folder is set in the "select a savefilename" dialog window.

@pep8speaks
Copy link

pep8speaks commented Apr 17, 2019

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-17 15:15:13 UTC

@jnsebgosselin jnsebgosselin merged commit 85007d6 into master Apr 17, 2019
@jnsebgosselin jnsebgosselin deleted the brf_backward_compat branch April 17, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants