Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add an undo feature when making changes to the water level data #270

Merged
merged 29 commits into from
Feb 13, 2019
Merged

PR: Add an undo feature when making changes to the water level data #270

merged 29 commits into from
Feb 13, 2019

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Feb 13, 2019 •
edited
Loading

  • Added an undo feature that allows to undo the last changes made to the water level data
  • Added an clear feature that allows to undo all changes made to the water level data since the last commit.
  • Created a WLDataFrameBase and WLDataFrame classes that holds all the code for the undo feature.

undo_cancel_changes

@jnsebgosselin
Add a missing docstring
fc9be5e
@jnsebgosselin
Start btn_commit_changes not enabled
ed61eb6
@jnsebgosselin
Add a clear_changes icon from mdi iconset
5f4eada
@jnsebgosselin
WLCalc: add a new _wldset_undo_stack class var
a59fadc
@jnsebgosselin
Add _add_to_undo_stack method
8c2f96e 
Store the old water level values at the specified indexes in a stack
before changing or deleting them. This allow to undo or cancel any
changes made to the water level data before commiting them.
@jnsebgosselin
Disable btn_commit_changes and btn_clear_changes
8fb7252
@jnsebgosselin
Add a clear_all_changes method
373285e 
Clear all changes that were made to the wldset.
@jnsebgosselin
Modify delete_selected_wl to use undo
de8d499
@jnsebgosselin
Modify commit_wl_changes to use undo
9aea061
@jnsebgosselin
Add a btn_clear_changes
e54a52f
@jnsebgosselin
Codestyle changes
4c5391a
@jnsebgosselin
Create a new WLDataFrameBase class
303f158
@jnsebgosselin
Imports
adb2bfd
@jnsebgosselin
Create a WLDataFrame class
8ba228a
@jnsebgosselin
if __name__ == "__main__":
3122ea4
@jnsebgosselin
Add a undo_changes icon
55c8ebc
@jnsebgosselin
Change the projet check
b9ff3d7 
It was not working well
@jnsebgosselin
Codestyle changes
047147e
@jnsebgosselin
Make WLDataFrameHDF5 inherit from WLDataFrameBase
8879628
@jnsebgosselin
Add code to handle changes to data and undo
b836ec9
@jnsebgosselin
Add code to commit changes
8622c40
@jnsebgosselin
Codestyle changes
41fd7ea
@jnsebgosselin
Use the undo capability of the dataset instead
a5f836f
@jnsebgosselin
Don't return a copy
3d2aec8 
This makes the operation on the data slow. It's less secure though.
@jnsebgosselin
Return a copy of the dataset from the hdf5file
0fe8868 
Otherwise, the commit feature is broken
@jnsebgosselin
Save a copy of the data in the hdf5file
0a53c19
@jnsebgosselin
Connect button to undo slot
dad3137
@jnsebgosselin
Fix clear_all_changes method
1854bcf
@jnsebgosselin jnsebgosselin added this to the gwhat-0.4.0 milestone Feb 13, 2019
@jnsebgosselin jnsebgosselin self-assigned this Feb 13, 2019
@jnsebgosselin jnsebgosselin merged commit 718bb8c into master Feb 13, 2019
@jnsebgosselin jnsebgosselin deleted the add_undo_capa branch February 13, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Analyse Hydrograph type: new feature
Projects
None yet
Milestone
gwhat-0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsebgosselin