Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add an option to mute the confirmation dialog when deleting a dataset #258

Merged
merged 12 commits into from
Feb 6, 2019
Merged

PR: Add an option to mute the confirmation dialog when deleting a dataset #258

merged 12 commits into from
Feb 6, 2019

Commits on Feb 6, 2019

  1. Add QCheckBox to imports

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    2dc6b7f View commit details
    Browse the repository at this point in the history

  2. Add confirm_del_dataset method 

    Show a message box asking the user confirmation before deleting a
dataset. Return the user's answer and whether the 'do not show this
message again' checkbox has been checked or not.
    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    657a8db View commit details
    Browse the repository at this point in the history

  3. Add _confirm_before_deleting_dset class var

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    7a7a4d0 View commit details
    Browse the repository at this point in the history

  4. Refactor del_current_wldset

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    073667d View commit details
    Browse the repository at this point in the history

  5. Refactor del_current_wxdset

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    1b75c06 View commit details
    Browse the repository at this point in the history

  6. Add sig_new_console_msg signal and connect it

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    eb7b48b View commit details
    Browse the repository at this point in the history

  7. Flush to file after deleting a dataset

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    8208808 View commit details
    Browse the repository at this point in the history

  8. Change tests to cover this new feature

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    0cfc23d View commit details
    Browse the repository at this point in the history

  9. Test that sig_new_console_msg is emitted

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    2433f31 View commit details
    Browse the repository at this point in the history

  10. Reduce vertical space with checkbox

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e31491a View commit details
    Browse the repository at this point in the history

  11. Increase waitSignal timeout

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    ba45ebf View commit details
    Browse the repository at this point in the history

  12. Dont waitSignal because it is not working

    @jnsebgosselin
    jnsebgosselin committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    3026746 View commit details
    Browse the repository at this point in the history