Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Improve how the BRF period is set and plotted #240

Merged
merged 44 commits into from
Dec 20, 2018
Merged

PR: Improve how the BRF period is set and plotted #240

merged 44 commits into from
Dec 20, 2018

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Dec 18, 2018 •
edited
Loading

Fixes #239
Fixes #204

  • Save the last selected BRF period for each dataset.
  • Plot the BRF period only when the BRF widget tab is visible.
  • Make the tests for the BRF independent.
  • Link changes made to the BRF calculation period from the BRF widget with the period displayed on the graph.
  • Reset the BRF calculation period when the selection process is cancelled.

demo_brf_selection

@jnsebgosselin jnsebgosselin added this to the gwhat-0.3.4 milestone Dec 18, 2018
@jnsebgosselin jnsebgosselin self-assigned this Dec 18, 2018
@pep8speaks
Copy link

pep8speaks commented Dec 18, 2018 •
edited
Loading

Hello @jnsebgosselin! Thanks for updating the PR.

Comment last updated on December 19, 2018 at 19:45 Hours UTC

@jnsebgosselin
Minor codestyle changes
fcec1c1
@jnsebgosselin
Show brf period only when tool is visible
bb23e67
@jnsebgosselin
... complete last commit
8adb25c
@jnsebgosselin
Fix test_install_kgs_brf
cf2bf0c
@jnsebgosselin
Emit brfperiod signal
577cab2
@jnsebgosselin
Make brfperiod a list instead of tuple
f213b94
@jnsebgosselin
Untoggle brf period selection
fcaae3b
@jnsebgosselin
Handle when brf selection is cancelled
7abf30b
@jnsebgosselin
Reduce datafile size and save as csv
d4ceee7 
This is better than xlsx since it is not binary
@jnsebgosselin
Flush to file after saving brfperiod
8bd0549
@jnsebgosselin
Remove superflux logic
d024f7b
@jnsebgosselin
Save brf period when widget value change
99e1327
@jnsebgosselin
Add tooltip to self.btn_seldata
df4ee46
@jnsebgosselin
Rename __init_figure__ to _setup_mpl_canvas
2dc48b1
@jnsebgosselin
Use OnOffToolButton for self.btn_seldata
10bfdca
@jnsebgosselin
Refactoring of toggle_brfperiod_selection
cc9a586
@jnsebgosselin
set_daterange refactoring
b4d4b35
@jnsebgosselin
Connect sig_brfperiod_changed again
5a5029c
@jnsebgosselin
Skip test_worker_updates on Travis
b30674a 
It fails too often
@jnsebgosselin
Sort values when setting the brfperiod
396e389
@jnsebgosselin jnsebgosselin merged commit d6a7476 into master Dec 20, 2018
@jnsebgosselin jnsebgosselin deleted the fix_brf_period_switching branch December 20, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Compute BRF type: bug type: enhancement
Projects
None yet
Milestone
gwhat-0.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks