PR: Use text instead of icons to label the tabs of the tab widget in which the tools to analyse the hydrograph are displayed and add tooltips. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the icons look great but they do not help very much to tell a new user what each tab is about. So I think it is better and cleaner to simply use text. Especially since there was not a dedicated icon for the BRF yet.
Also, this new layout takes up less vertical space, so this is a step forward in fixing #152.
Finallly, I added a tool-tip for each tab that describes a little better what each tool is.
Now
Before