PR: Correct the calculation of GLUE by correcting the definition of the likelihood function. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsebgosselin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Beven and Binley, 1992 regarding the informal LIKELIHOOD FUNCTIONS:
By mistake, the RMSE was used directly as the likelihood function instead of the inverse of the RMSE. This caused the simulations that are considered to exhibit behaviour dissimilar to the system to have more weight than those that exhibit behaviour more similar to the system.
The impact on the estimated values of groundwater recharge should be minimal though because all behavioural models produced for the evaluation of groundwater recharge had a RMSE quite similar in all cases, since all the "bad" models were discarded a-priori.