Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add various improvements to the FigureStackManager and add a new figure that shows the yearly water budget. #181

Merged
merged 25 commits into from
Apr 16, 2018
Merged

PR: Add various improvements to the FigureStackManager and add a new figure that shows the yearly water budget. #181

merged 25 commits into from
Apr 16, 2018

Conversation

jnsebgosselin
Copy link
Owner

@jnsebgosselin jnsebgosselin commented Apr 16, 2018 •
edited
Loading

The goal of this PR is to make the FigureStackManager more modular and to add a figure that shows the yearly water budget.

  • Add panels to control text properties and x-axis and y-axis range.
  • Make the panel and figure creation more modular.
  • Improvements to the design of the yearly glue recharge graph.
  • Add a new yearly water budget default figure.
  • Only one instance of the FigureStackManager is shown at a time. Each time groundwater recharge is computer, the figure are updated instead of popping a new window.

image

image

@jnsebgosselin
Remove the need to subclass the figure manager
f2eb75a
@jnsebgosselin
Update margins when fig size is changed
44ed9ae
@jnsebgosselin
calcul glue yearly for all components
72e52b1
@jnsebgosselin
Set xlimits and ylimits in a method
cbea7c4
@jnsebgosselin
Set xlimits and ylimits in a method
cfb03ae
@jnsebgosselin
Add a new figure that plot the water budget
1c529bb
@jnsebgosselin
Add widgets to control x and y axis limits
30c95cd
@jnsebgosselin
Improve the graph that plots yearly rechg results
ca57748
@jnsebgosselin
Setup xticklabels when ylimits are changed
0a66945
@jnsebgosselin
Fix a bug when deltat is not 0
a181633
@jnsebgosselin
Change a QLabel text
159af3b
@jnsebgosselin
Setup xticklabels manually for recharge too
45395d1
@jnsebgosselin
Remove duplicate def of ticklabels
69bb41e
@jnsebgosselin
Improve legend location
8dbeefd
@jnsebgosselin
Make setp panels more modular
a0b0145
@jnsebgosselin
Make only one FigureStackManager
71ed913
@jnsebgosselin
Update imports
a9b4ae7
@jnsebgosselin
Remove Qt.WA_DeleteOnClose
2faa577
@jnsebgosselin
Add a new panel to control test properties
075ba39
@jnsebgosselin
Prevent verticalscrollbar from hiding the opt panel
4b150a6
@jnsebgosselin
Define new option in setp
ffb9719
@jnsebgosselin
Move setup legend in a method
e2a0438
@jnsebgosselin
Add text opt panel to the canvamanagers
56c150d
@jnsebgosselin
Normalize the method to plot
aa448bc
@jnsebgosselin
Make the plot work with setp by normalizing
b927c2e
@jnsebgosselin jnsebgosselin added this to the gwhat-0.3.0 milestone Apr 16, 2018
@jnsebgosselin jnsebgosselin self-assigned this Apr 16, 2018
@pep8speaks
Copy link

Hello @jnsebgosselin! Thanks for submitting the PR.

Line 299:1: W293 blank line contains whitespace
Line 338:1: W293 blank line contains whitespace

@jnsebgosselin jnsebgosselin merged commit 7f29443 into master Apr 16, 2018
@jnsebgosselin jnsebgosselin deleted the add_waterbudget_fig branch April 16, 2018 13:52
@jnsebgosselin jnsebgosselin mentioned this pull request Apr 20, 2018
Merged
@jnsebgosselin jnsebgosselin mentioned this pull request May 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Groundwater Recharge Estimation
Projects
None yet
Milestone
gwhat-0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jnsebgosselin @pep8speaks