Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Make the saving of the hydrograph figure more robust #179

Merged
merged 5 commits into from
Apr 12, 2018
Merged

PR: Make the saving of the hydrograph figure more robust #179

merged 5 commits into from
Apr 12, 2018

Conversation

jnsebgosselin
Copy link
Owner

Fixes #177

  • Prevent GWHAT from crashing when the save button is clicked but no hydrograph is actually plotted.
  • Prevent GWHAT from crashing when saving a figure in a file that is opened in another application.
  • Add a number at the end of the proposed figure name if the default name already exist.
  • Add the option to save the figure to png.

@jnsebgosselin jnsebgosselin added this to the gwhat-0.3.0 milestone Apr 12, 2018
@jnsebgosselin jnsebgosselin self-assigned this Apr 12, 2018
@jnsebgosselin jnsebgosselin changed the title PR: Make save hydrograph more robust PR: Make the saving of the hydrograph figure more robust Apr 12, 2018
@jnsebgosselin jnsebgosselin merged commit 0e1fcb3 into master Apr 12, 2018
@jnsebgosselin jnsebgosselin deleted the make_save_hydrograph_more_robust branch April 12, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsebgosselin jnsebgosselin

Labels
component: Plot Hydrograph type: bug
Projects
None yet
Milestone
gwhat-0.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsebgosselin