PR: Refactoring and adding tests for the brf module. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsebgosselin
changed the title
|
Hello @jnsebgosselin! Thanks for updating the PR.
Comment last updated on December 22, 2017 at 15:32 Hours UTC |
Until I can debug this on a real machine, I'm going to skip this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to use the new
__rootdir__variable that was introduced in PR #123 to define the directory wherekgs_brf.exeis installed.Also, the code of the
kgs_brfmodule will be cleaned and new tests will be written.Finally, some message will be added to tell the user that the BRF feature is currently not available on operating systems other than Windows. Unfortunately, I do not have the time to support fully a version on Linux... :(