PR: Refactoring of the tool to import water level and daily weather datasets. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jnsebgosselin! Thanks for updating the PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of PR #124 that was a partial fix for Issue #105.
This work is motivated by the work that is currently ongoing in PR #104 where documentation is being written about the management of the data in GWHAT. I discovered that it was hard to document this section elegantly because there was too much differences between the way weather and water level datasets were imported in GWHAT.
This PR also cleans a lot the code in
manager_data.py. More than 150 lines of code were thus removed.