PR: Update the "About GWHAT" window and reduce startup time. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating the GWHAT window on startup, it is created only when the button about gwhat is clicked.
|
Hello @jnsebgosselin! Thanks for updating the PR.
Comment last updated on December 11, 2017 at 21:51 Hours UTC |
|
For the record, here is a screenshot of the About GWHAT window before this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to update the text in the
About GWHATwindow to reflect the changes that were made for the copyrights of the software.Also, in this PR the creation of the
About GWHATwindow is delayed when it is actually required, instead of generating it on startup. The objective is to reduce the startup time of GWHAT as discussed in Issue #56.