-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Major improvements of the tool to evaluate groundwater recharge. #119
Conversation
- Moved all the plot related methods to a new module - Made rechg calcul in an independent thread - Added a progressbar
The plotting of the results is still a little bit slow, but this is going to be for another PR. This one is big enough. The axis labels are not displayed correctly though, I need to fix that because I can merge. |
Ok, that was not the plotting that was slow. I forgot to remove a line of codes that I added for testing and that was saving the results to a numpy binary. This is what was causing the lag in the production of the figures. |
Note that an option should be added in the GUI.
Here what features are still missing after this patch:
|
Fixes #80 and Fixes #72
The goal of this PR is to improve the tool to evaluate groundwater recharge. This was included in WHAT in version 4.2.0-beta with some major ninja hacking. This PR cleans this up and includes some major performance improvements with the use of the
cython
package to improve some routines that were taking too much calculation time inPython
.In summary, this PR:
pyplot
interface for plotting the results.