PR: Fixes crash when trying to add PET to an existing file and added some tests. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned the code and renamed the function to add PET to an existing weather datafile.
Changed all ETP to PET as it should be in the English language.
|
Hello @jnsebgosselin! Thanks for updating the PR.
Comment last updated on November 30, 2017 at 22:52 Hours UTC |
|
While running the tests, a new bug was found with the following traceback: Traceback (most recent call last):
File "C:\Users\jsgosselin\GWHAT\gwhat\meteo\gapfill_weather_gui.py", line 675,
in gap_fill_btn_clicked
self.msgBox.setText('No <b>weather station</b> is currently ' +
AttributeError: 'GapFillWeatherGUI' object has no attribute 'msgBox'This bug occurs when clicking on the |
jnsebgosselin
added a commit
that referenced
this pull request
Dec 4, 2017
…some tests. (#107) * Support for importing .csv weather data input files * Reworked and renamed the function Cleaned the code and renamed the function to add PET to an existing weather datafile. * Fixe broken import in the code * Improved label and tooltip of add PET option * Reworked tooltip and variable names Changed all ETP to PET as it should be in the English language. * Updated the documentation * Added tests to test Add PET feature. * Fixed bug about QMessageBox * fixed the tests
jnsebgosselin
added a commit
that referenced
this pull request
Jan 5, 2018
* Corrected a format typo * Updating link to getting started docs * PR: Fixes crash when trying to add PET to an existing file and added some tests. (#107) * Support for importing .csv weather data input files * Reworked and renamed the function Cleaned the code and renamed the function to add PET to an existing weather datafile. * Fixe broken import in the code * Improved label and tooltip of add PET option * Reworked tooltip and variable names Changed all ETP to PET as it should be in the English language. * Updated the documentation * Added tests to test Add PET feature. * Fixed bug about QMessageBox * fixed the tests * Section Import data of plot hydrograph * Working on section Input data files format * PLotting the Hydrograph section * PR: Fix water_level_measurements file management (#108) * Removed dead imports * Moved function to another module Moved the function to create an empty water_levels_measures file to the module read_waterlvl. Also, removed the code to create an empty graph_layout.lst because it is not used anymore. * New water_level_measures and support for csv and xls Added support for csv and xls file for reading the water_level_measurement file. * Added code to determine the ext of the file * Added a property to return projet dirname * Init the water_level_measurement on loading When loading a project, the water_level_measurement is initialize automatically by default. * Make function xls/xlsx format aware * cleaned not needed imports * Added a basic test * Fix a bug with extension search * Fix when adding water lvl meas to project The dataset size were not expanded to receive the data, so in the end, no data was added to the dataset. * init requirements file * Added tests to test management of wl meas. * Added a simple test for HydroCalc init * Extended test coverture * Updated coverall badge and link to roadmap * Fixed and reworked filt_data code (#109) * PR: Small GUI improvements of the Page and Figure Setup Dialog window. (#111) * Improved layout and code style of PageSetupWin * Make radiobuttons to align to the right * Changed the version number for the release * Work on the figures and document structure * Completed the Color setup section * Completed section Page and Figure Setup * Completed the manual measurements section * Moved import data in its own chapter * Added text and reordered the authors * Changed copyrights to GWHAT Documentation Contributors * Writing Manage Data section * Corrected a small format typo * New image with annoted dataset manager panel * updated the dialog scs to show actual data * Working on the text * Working on the text. * First draft of section Importing Data * Reworked section Managing Data * Still working on the Plotting the Hydrograph section * Fixed a wrong link * Added instruction for zoom in and out of the fig canvas * Moved the water lvl meas file * Work on the docs * Components water level and Missing Data * Changed the color of the text * Work-in-progress comp. air temp. * Finished the first draft of Plotting the Hydrographs section * Completed writing the Plotting the Hydrograph sec! * Some corrections to section Manage Data * Revision "Data Management in GWHAT" * Revision "Plotting the Hydrographs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #40
This bug was introduced when the function
add_ETP_to_weather_data_filewas moved to the moduleweather_reader.py, but the namespace was not updated accordingly in the modulegapfill_weather_gui.pyWhile fixing this bug:
Fill Stationbutton when no station was selected.