-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marquee text #754
base: redesign
Are you sure you want to change the base?
marquee text #754
Conversation
marquee effect on song title
Merge pull request #1 from Decimate1405/marquee
fixed non marquee text alignment issue
Hey, thanks for the PR. Sorry for not responding sooner, but I'll take a look now. If you could update this PR to behave in a similar way (using up to two lines by default, and then switching to scrolling text) that would be nice. If you don't like the line break and would like to always keep it at a single line, that could be added through a setting! Also, it seems like you removed the track title on the player screen? |
Hey, thank you for the response. I tried using marquee package but it was giving an error during import (some conflict with fading_edge_scrollview package) that's why I implemented it myself. I think adding it as a setting would be really nice as it would accommodate for everyone's needs. Regarding the title being removed from the player screen, looks like I accidentally forgot to remove the comment. |
added a toggle to switch between 1 or 2 lines of song title, defaults to 2. its under Player settings. |
Okay, thanks for the changes. There's still a lot of commented-out code, that should be removed. |
There's no specific benefit to using my implementation. I couldn't fix the errors i was getting while using the marquee package so i got fed up and implemented it myself. I'll give it another go |
Try adding the override from MarcelGarus/marquee#98 (comment) in pubspec.yaml :) |
…that's a temp fix for marquee after flutter 3.2.2
changed it to use the marquee package, still defaults to 2 lines |
…r based on toggle switch and title size
…ine marquee duplicates for short titles
Appreciate the effort! Those changes sound good. Let me know when I should try this out! |
its working, you can try it now :) |
…or on the now playing bar adapts to the theme. Fixed bug where with the one line marquee enabled, even non-overflowing text uses a marquee on the player screen.
Taking a look now, I missed your comment, sorry about that. By "track menu", I meant the menu that opens when tapping the "hamburger icon" or three dot icon, with options like "add to playlist", "go to artist", etc. From your screenshot it seems like you added the marquee to the track list within albums and playlists, which is probably a bit overkill... |
oh, I thought you meant track/album menu which did seem a bit off to me. i can move it to the hamburger menu |
I also think there's no need to add marquees for all the other tracks in the queue list. Just the currently playing track should be enough, otherwise there's too much movement on the screen. But I'd like to hear your opinion. |
i do agree, when i was testing it out having marquee in the queue list seemed very off because none of the tracks are synced because of their title length. I only implemented it because I thought that's the change you were referring to |
Yes. That's how it should be :) I also noticed that the height required by marquee text and two-line wrapped text isn't equal. Previously I made sure that one line and two line titles had the same height (single line was centered vertically), so that so layout shift between tracks happens. (tried to record a video of the problem, but my screen recorder doesn't like me) |
oh ok. yea I intentionally changed the height between one line and two line because i thought it would look cleaner. but i can keep it the same |
Also, please add a "Scroll text instead of truncating" setting to the customization settings at, it can default to be enabled. You might also wanna move the other setting over there, since it doesn't only affect the player screen anymore :) |
Okay, here's the layout shift I was talking about: 2024-06-05-00-01-38.mp4 |
is this layout fix good or should i change something? |
No, add a new setting that controls if a marquee is used at all (or if the previous behavior with the ellipsis is always used) and move the other setting Or you could try to combine those two settings in a select/dropdown list. |
@Decimate1405 are you still willing to work on this? I can handle the merge conflict for you, if that helps? |
Yes, last few days have been quite busy but i can continue working on it this weekend. Could you just summarize what other features are needed. The last change I made was the layout fix |
That's great to hear!
Hopefully nothing major :) |
…ttings and renamed it "Allow one line break before using scrolling text"
…es instead of using marquee
Hey, just saw you added commits to this. Is this ready to re-review? If so, would you mind resolving the merge conflicts? :) |
Implemented marquee text in song menu for overflow, instead of two lines