Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arabic language #256

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Add Arabic language #256

merged 4 commits into from
Apr 14, 2022

Conversation

AYMENJD
Copy link
Contributor

@AYMENJD AYMENJD commented Apr 13, 2022

No description provided.

@hugovk
Copy link
Collaborator

hugovk commented Apr 13, 2022

Please could you merge or rebase from master? The CI failure should be fixed.

@hugovk hugovk added the changelog: Added For new features label Apr 13, 2022
@AYMENJD
Copy link
Contributor Author

AYMENJD commented Apr 13, 2022

Please could you merge or rebase from master? The CI failure should be fixed.

Done.

@hugovk
Copy link
Collaborator

hugovk commented Apr 13, 2022

Thanks! There's now some errors with the new translation:

ar_SA
src/humanize/locale/ar_SA/LC_MESSAGES/humanize.po: warning: Charset "CHARSET" is not a portable encoding name.
                                                            Message conversion to user's charset might not work.
src/humanize/locale/ar_SA/LC_MESSAGES/humanize.po:[12](https://github.com/jmoiron/humanize/runs/6014189134?check_suite_focus=true#step:7:12)2: message catalog has plural form translations...
src/humanize/locale/ar_SA/LC_MESSAGES/humanize.po:7: ...but header entry lacks a "plural=EXPRESSION" attribute
src/humanize/locale/ar_SA/LC_MESSAGES/humanize.po:122: message catalog has plural form translations...
src/humanize/locale/ar_SA/LC_MESSAGES/humanize.po:7: ...but header entry lacks a "nplurals=INTEGER" attribute
src/humanize/locale/ar_SA/LC_MESSAGES/humanize.po:7: warning: header field 'Content-Type' still has the initial default value
msgfmt: found 2 fatal errors

@AYMENJD
Copy link
Contributor Author

AYMENJD commented Apr 13, 2022

@hugovk Should be fixed now.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #256 (fe4b17e) into master (94b3332) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files           9        9           
  Lines         635      635           
=======================================
  Hits          633      633           
  Misses          2        2
Flag Coverage Δ
GHA_Ubuntu 98.42% <ø> (ø)
GHA_Windows 98.11% <ø> (ø)
GHA_macOS 98.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b3332...fe4b17e. Read the comment docs.

@hugovk
Copy link
Collaborator

hugovk commented Apr 14, 2022

Thank you!

@hugovk hugovk changed the title Add Arabic language. Add Arabic language Apr 14, 2022
@hugovk hugovk merged commit 0d1aae6 into jmoiron:master Apr 14, 2022
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 27, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
423524c 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 27, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
5145124 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 27, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
d8e6455 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 28, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
5ab9605 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 28, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
7af5eba 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 28, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
370c961 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 28, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
e8178cb 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request May 29, 2022
@kraj
python3-humanize: upgrade 4.0.0 -> 4.1.0
760b96f 
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
@kraj
src/meta-openembedded:python3-humanize: upgrade 4.0.0 -> 4.1.0
cf4922f 
Changelog:
==========
Added
------
    Support Python 3.11 (#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (#2)

Fixed
-------
    Removed VERSION from __all__ (#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
@kraj
src/meta-openembedded:python3-humanize: upgrade 4.0.0 -> 4.1.0
b4e92c6 
Changelog:
==========
Added
------
    Support Python 3.11 (#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (#2)

Fixed
-------
    Removed VERSION from __all__ (#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Added For new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AYMENJD @hugovk @codecov-commenter