Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media import dialog with thumbnails #1213

Merged
merged 1 commit into from
May 9, 2016
Merged

Conversation

ubertao
Copy link
Contributor

@ubertao ubertao commented May 9, 2016

This PR changes import costumes/backgrounds menu to dialog boxes with thumbnails of media, making import process more intuitive/fun.

Given the limited size of current media library, pagination was not implemented, this is something should be improved in the future.

Screenshots:
import
import-bg

@jmoenig
Copy link
Owner

jmoenig commented May 9, 2016

Oh wow. This is really beautiful! Thank you, I'll pull this later today and integrate it right away!!

@towerofnix
Copy link
Contributor

This looks great! Will it cause an issue on devices with access to bad internet, though? If the preview image loading is synchronous, it may take these devices a long time to open up the media library.

@ubertao
Copy link
Contributor Author

ubertao commented May 9, 2016

Once the library file is read, the dialog will open right away with place holder images (currently the turtle icon, sorry I couldn't find a more proper resource for loading status), then thumbnails will be loaded in background.

@jmoenig jmoenig merged commit b98e732 into jmoenig:master May 9, 2016
@cycomachead
Copy link
Collaborator

This is really awesome! 👍

My only quibble is that the background color of the dialog looks off.

I'll add an issue about pagination later. Now that graphics are done, it'd be great to implement the same thing as a preview for the sounds dialog, where you get a grid of play buttons.

@jmoenig
Copy link
Owner

jmoenig commented May 9, 2016

Don't worry, @cycomachead , I've already fixed that, and I'm also working on a few other small issues...

@jmoenig
Copy link
Owner

jmoenig commented May 9, 2016

Thanks again, @ubertao ! I've tweaked your contribution somewhat, mostly making the dialog box resizable, the icons double-clickable and avoiding some causes of minor JS errors: 711b9a4
But the original contribution and the design of it is still very much yours. I hope you don't mind, this is great, I really appreciate it!

Oh, and it's now online!

@ubertao
Copy link
Contributor Author

ubertao commented May 10, 2016

Great, this is definitely better!

NaveedMohammed pushed a commit to c2stem/snap-physics that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants