[currency] - add span attributes (open-telemetry#265)

* add conversion from/to attributes * currency service attributes
jmichalak9 · Aug 5, 2022 · 128f78f · 128f78f
1 parent 7dd5727
commit 128f78f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -55,3 +55,5 @@ significant modifications will be credited to OpenTelemetry Authors.
 ([#255](https://github.com/open-telemetry/opentelemetry-demo/pull/255))
 * Added spanmetrics processor to otelcol
 ([#212](https://github.com/open-telemetry/opentelemetry-demo/pull/212))
+* Added span attributes to currency service
+([#265](https://github.com/open-telemetry/opentelemetry-demo/pull/265))
diff --git a/docs/manual_span_attributes.md b/docs/manual_span_attributes.md
@@ -28,7 +28,8 @@ This document contains the list of manual Span Attributes used throughout the de
 
 ## CurrencyService
 
-* None yet
+* `app.currency.conversion.from`
+* `app.currency.conversion.to`
 
 ## EmailService
 

diff --git a/src/currencyservice/src/server.cpp b/src/currencyservice/src/server.cpp
@@ -185,6 +185,9 @@ class CurrencyService final : public hipstershop::CurrencyService::Service
       getUnitsAndNanos(*response, final);
       response->set_currency_code(to_code);
 
+      span->SetAttribute("app.currency.conversion.from", from_code);
+      span->SetAttribute("app.currency.conversion.to", to_code);
+
       // End the span
       span->AddEvent("Conversion successful, response sent back");
       span->SetStatus(StatusCode::kOk);