-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from HEAT to COOL mode #144
Conversation
Please rebase and I would be glad to merge ! |
I think it is more complicated than this. In the code, it is checked if the VTherm is in ac_mode instead of checking is the VTherm is in HVACMode COOL. See example in base_thermostat.py line 268. So you will have to change all this code and see if all unit tests are running. I guess not. |
I did the chance on top of your last chance today the rebase should not be
needed, I guess.
On the first pull request it was working fine all unit tests are passed
without errors
Il Lun 30 Ott 2023, 15:15 Jean-Marc Collin ***@***.***> ha
scritto:
… I think it is more complicated than this. In the code, it is checked if
the VTherm is in ac_mode instead of checking is the VTherm is in HVACMode
COOL. See example in base_thermostat.py line 268.
So you will have to change all this code and see if all unit tests are
running. I guess not.
—
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTEWF4AJPBFGSMRBBI6LDYB6Y7ZAVCNFSM6AAAAAA6VSAMC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGMYTEMBRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I finish an important development about regulation and I come back with your PR. |
I wonder why I see all my commits into you PR. Did you have some troubles with the rebase ? |
I did the rebase but maybe I did something of wrong
Let me try to resolve the issue on my end by tomorrow.
Il giorno mer 1 nov 2023 alle ore 21:18 Jean-Marc Collin <
***@***.***> ha scritto:
… I wonder why I see all my commits into you PR. Did you have some troubles
with the rebase ?
—
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTEWH2SP67GI45VMPE5MTYCKVBRAVCNFSM6AAAAAA6VSAMC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGYYTMMJZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
What i suggest is to restart from scratch. Checkout the main branch and
redo your work
Le mer. 1 nov. 2023, 21:21, Andrea Nicotra ***@***.***> a
écrit :
… I did the rebase but maybe I did something of wrong
Let me try to resolve the issue on my end by tomorrow.
Il giorno mer 1 nov 2023 alle ore 21:18 Jean-Marc Collin <
***@***.***> ha scritto:
> I wonder why I see all my commits into you PR. Did you have some
troubles
> with the rebase ?
>
> —
> Reply to this email directly, view it on GitHub
> <
#144 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AALTEWH2SP67GI45VMPE5MTYCKVBRAVCNFSM6AAAAAA6VSAMC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGYYTMMJZGY>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANCB5UQQE4I6IIHYUB2KWTYCKVK3AVCNFSM6AAAAAA6VSAMC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGYYTSNRUGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
yes, it is what I did "reset from your main then cherry-pick from my local
branch", I did the squash of 2 changes hoping it is not a problem.
|
Merged ! Thank you. It will be in the next release. |
Hello Collin,
I need the capability to switch from HEAT to COOL mode, does it make sense for you?
I have an aermec unit which can generate both cooling and heating, it is managed by ZBMINI-L2 ZigBee, if the thermostat is configured in AC mode I would like support both.
unit test updated as well!