-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the temperature preset persistent entities #354
Comments
Be careful to the migration: how to keep the configured values. Should we remove the central configuration for preset temperature as well ? Or just init the values of the new entities with the central configuration values ? Then we lost the diffusion of changing a central configuration to all VTherm. |
This would be awesome 👏 |
Thank you for your feedback, I was pretty sure, you will be interested 😉 |
If it is easier during migration to leave the config in place, then perhaps the config values become "initial value" used until someone changed them. This might allow newly defined VTherms to have a value before the user defines a UI for changing values, and covers the scenario where a VTherm exists without a UI. |
I'm really looking forward to this enhancement :-) I'm planning a UI like this as i short list for all my climate entities on each floor(and one for the whole house). I have many climate entities and I need a place to get quick glance over them all. Its not usable to have to maneuver through many "room" cards for this. And when you have made the preset-temperatures an alterable entity in the UI, I will be able to enhance my “card” with a “Hold-action” over the preset-mode buttons to let the user alter the preset temps right there. |
Oh that's great, can you please share how you managed to create that UI? I was trying a super-compact layout as well but gave up. This here is what I managed using multiple-entity-row, but the icons did not change state depending on the selected preset, and that was rather unusable. |
I love your card and the compacity. Maybe an idea for a future UI card given out of the box by the VersatileThermostat UI Card. I will keep that in my TODO list, if you agree with that. |
On the development of this feature itself, it is finally very complex and I'm running into race conditions:
So it is a nightmare to have all initialized depending on all configuration options. 😮💨 |
That's fine with me. Just happy to contribute 😀 |
I sense that you may have painted yourself into a corner with the central-config system. As it seems from your bullet list. 😜 When a user upgrades the VT-system (with the new preset-temp entities release). You make(generates) preset-temp entities for the already configured VT-devices, and preloads them with the temp values from the existing VT-config. The new solution with preset-temp entities would open many new possibilities regarding altering many presets at one time(that I sense is one of the benefits with the central-config). Users can e.g make an easy script that alters all the preset-entities for vt-Thermostats in e.g certain areas or all of them at ones. Does this give any meaning ? |
Thank you @gunmalmg for your tips. That is aproximatively what I'm trying to do to keep as much as possible the current behavior:
My concern was much about the startup dependencies but I found something to deal with that. |
Hello, I have developed this improvement. It is available here for testing in a real environment: https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.0.0.alpha1 Caution it may contains bug because it has made many important changes and refactoring. If you can test in // of me, it could be great. Please use this discussion if more information are needed: #404 |
Exiting
I'll test it. But it will take some days - before I have the time. :-)
Med vennlig hilsen
*Horisont Eiendom AS <https://tingsakertorv.no/horisont-eiendom> /
Lillesand Senter <http://lillesandsenter.no> / Agder Helsepark
<https://tingsakertorv.no/forside-helse> / Tingsaker Torv
<https://tingsakertorv.no/om-tingsaker-torv> / Horisont Utvikling
<https://tingsakertorv.no/om-tingsaker-torv>*
*Gunnar Malmgård*
Tlf: 91686522,
***@***.***
Senterveien 30, 4790 Lillesand
søn. 10. mars 2024 kl. 19:09 skrev Jean-Marc Collin <
***@***.***>:
… Hello, I have developed this improvement. It is available here for testing
in a real environment:
https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.0.0.alpha1
Caution it may contains bug because it has made many important changes and
refactoring. If you can test in // of me, it could be great.
—
Reply to this email directly, view it on GitHub
<#354 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6ULHFZYTVWFXLXZ7VL6VDDYXSOXDAVCNFSM6AAAAABCD2EUJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGMYTGOBYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Here is some examples of me playing around with UI possibilities : Bibliotek.-.2.av.2.1.movBibliotek.-.1.av.2.1.movThis is done by utilizing the more-info action. |
Thank you @gunmalmg for your valuable feedback. I will see what I take for the release (this week-end), all is working fine on my side also. |
https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.0.0 @gunmalmg I have rename the entities with preset. I don't have change the Number UI form to slider. My tries with a mobile device was not conclusive. The slider is very difficult to use. So I keep it like that and you can always long click on the entity to get the full configuration window. |
Changing a temperature preset should be simplier.
We could add some entities as domain
number
which can be changed easily in the VTherm and can be directly set into dabshboard.Then we can remove the configuration presets which will simplify the configuration.
As a general way, keep configuration which change rarely into the configuration panel and add persistent configuration entities for each parameters which can be modified. Target temperature is the good example.
The text was updated successfully, but these errors were encountered: