[Reporting] [Dashboard] Use ViewMode Only When Printing #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hopefully I'm not totally on the wrong track here, but I've updated the POC PR to use the new Print View Mode only, rather than another route. Additionally I have removed the copied code from the print viewport,
You can see this print mode without generating a PDF / PNG by adding
&_a=(viewMode:print)
onto the end of the dashboard URL. This does require a hard reload. This viewMode will be saved into session storage and persisted over migrations / reloads, so to leave it you have to inject&a=(viewMode:view)
into the URL. Again, a hard refresh will be required to make the panels load again.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers