Fix floating tools rendering logic (elastic#54505)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens · Jan 13, 2020 · c39d8e2 · c39d8e2
1 parent a64013f
commit c39d8e2
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 14 deletions.
diff --git a/...ns/console/public/np_ready/application/containers/editor/legacy/console_editor/editor.tsx b/...ns/console/public/np_ready/application/containers/editor/legacy/console_editor/editor.tsx
@@ -164,7 +164,7 @@ function EditorUI() {
 
     mappings.retrieveAutoCompleteInfo();
 
-    const unsubscribeResizer = subscribeResizeChecker(editorRef.current!, editor.getCoreEditor());
+    const unsubscribeResizer = subscribeResizeChecker(editorRef.current!, editor);
     setupAutosave();
 
     return () => {

diff --git a/.../public/np_ready/application/containers/editor/legacy/subscribe_console_resize_checker.ts b/.../public/np_ready/application/containers/editor/legacy/subscribe_console_resize_checker.ts
@@ -22,8 +22,15 @@ export function subscribeResizeChecker(el: HTMLElement, ...editors: any[]) {
   const checker = new ResizeChecker(el);
   checker.on('resize', () =>
     editors.forEach(e => {
-      e.resize();
-      if (e.updateActionsBar) e.updateActionsBar();
+      if (e.getCoreEditor) {
+        e.getCoreEditor().resize();
+      } else {
+        e.resize();
+      }
+
+      if (e.updateActionsBar) {
+        e.updateActionsBar();
+      }
     })
   );
   return () => checker.destroy();

diff --git a/...ugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts b/...ugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts
@@ -297,30 +297,30 @@ export class LegacyCoreEditor implements CoreEditor {
       // pageY is relative to page, so subtract the offset
       // from pageY to get the new top value
       const offsetFromPage = $(this.editor.container).offset()!.top;
-      const startRow = range.start.lineNumber - 1;
+      const startLine = range.start.lineNumber;
       const startColumn = range.start.column;
-      const firstLine = this.getLineValue(startRow);
+      const firstLine = this.getLineValue(startLine);
       const maxLineLength = this.getWrapLimit() - 5;
       const isWrapping = firstLine.length > maxLineLength;
-      const getScreenCoords = (row: number) =>
-        this.editor.renderer.textToScreenCoordinates(row, startColumn).pageY - offsetFromPage;
-      const topOfReq = getScreenCoords(startRow);
+      const getScreenCoords = (line: number) =>
+        this.editor.renderer.textToScreenCoordinates(line - 1, startColumn).pageY - offsetFromPage;
+      const topOfReq = getScreenCoords(startLine);
 
       if (topOfReq >= 0) {
         let offset = 0;
         if (isWrapping) {
           // Try get the line height of the text area in pixels.
           const textArea = $(this.editor.container.querySelector('textArea')!);
-          const hasRoomOnNextLine = this.getLineValue(startRow + 1).length < maxLineLength;
+          const hasRoomOnNextLine = this.getLineValue(startLine).length < maxLineLength;
           if (textArea && hasRoomOnNextLine) {
             // Line height + the number of wraps we have on a line.
-            offset += this.getLineValue(startRow).length * textArea.height()!;
+            offset += this.getLineValue(startLine).length * textArea.height()!;
           } else {
-            if (startRow > 0) {
-              this.setActionsBar(getScreenCoords(startRow - 1));
+            if (startLine > 1) {
+              this.setActionsBar(getScreenCoords(startLine - 1));
               return;
             }
-            this.setActionsBar(getScreenCoords(startRow + 1));
+            this.setActionsBar(getScreenCoords(startLine + 1));
             return;
           }
         }

diff --git a/...ore_plugins/console/public/np_ready/application/models/legacy_core_editor/smart_resize.ts b/...ore_plugins/console/public/np_ready/application/models/legacy_core_editor/smart_resize.ts
@@ -24,7 +24,7 @@ export default function(editor: any) {
   const resize = editor.resize;
 
   const throttledResize = throttle(() => {
-    resize.call(editor);
+    resize.call(editor, false);
 
     // Keep current top line in view when resizing to avoid losing user context
     const userRow = get(throttledResize, 'topRow', 0);