Use SHA-256 as the webpack hash function #10112
Conversation
|
Hi, thanks for your contribution! |
|
CLA already signed |
|
Jenkins please test this please. |
|
LGTM since I may need a bit more time to finish the Webpack 5 migration. |
|
Webpack 5.57.1 upgrade is completed on master, however, in order to benefit of xxhash64, experiments.futureDefaults should be enabled, which is not the case presently. I'm thinking we should go ahead and override the default with sha-256 for now, @saghul @jbg wdyt? |
|
Aren't we ok since we are on a newer Webpack version now? If not, this needs a rebase. |
|
Newer webpack still defaults to md4 unless you use |
|
Yes it does then, thank you! |
|
Please rebase this |
Webpack defaults to MD4 as the output hash function. MD4 was moved to the legacy provider in OpenSSL 3.0 and is not available by default. As a result, webpack fails to run on any system with OpenSSL 3.0 or later. This patch sets the hash function explicitly to SHA-256 which fixes the webpack build on such systems. SHA-256 is chosen as a reasonable modern default. An alternative solution would be to upgrade to webpack v5.54.0 or later and use webpack's future default hash function xxhash64, which doesn't depend on OpenSSL and is also faster than SHA-256. Related: lib-jitsi-meet#1743
|
Rebased. |
|
CI failure looks unrelated. |
|
an older commit on master i causing that |
|
Sorry, this fell through the cracks, can you please rebase this one last time @jbg ? |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Webpack defaults to MD4 as the output hash function. MD4 was moved to the legacy provider in OpenSSL 3.0 and is not available by default. As a result, webpack fails to run on any system with OpenSSL 3.0 or later.
This patch sets the hash function explicitly to SHA-256 which fixes the webpack build on such systems. SHA-256 is chosen as a reasonable modern default.
An alternative solution would be to upgrade to webpack v5.54.0 or later and use webpack's future default hash function xxhash64, which doesn't depend on OpenSSL and is also faster than SHA-256.
Related: jitsi/lib-jitsi-meet#1743