Implement Utf8Helper.getAllowedCharsets()
to lazy-load allowedCharsets
, make Utf8Helper.allowedCharsets
private
#176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that since 16.3.0, a simple instantiation of
SWF()
takes way longer than it previously did (around 2 vs .3 seconds on my computer). So I've pinpointed the issue to 4c6ccf0, which added anallowedCharsets
static variable inUtf8Helper
which was populated in astatic {...}
block even if it was never going to be used.This PR implements lazy-loading of
Utf8Helper.allowedCharsets
viaUtf8Helper.getAllowedCharsets()
, so that it does not waste time generating when not needed.