-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Yolov5 in GPU/CPU versions #200
Comments
Hi @jacobowitz it looks like this pull request has added all the changes required for a setup.py but the authors are holding off on integrating it as it would involve adding a yolov5 base directory, so they are looking for other options. Meanwhile the author has mentioned this 3rd party Pypi package as the best way to do inference right now which is the same as the fork you referenced. |
@hmen97 thank you for digging into this issue! Its a pity that yolov5 authors won't refactor their repo to enable a proper Pypi package :( |
Yeah I was thinking along the same lines, based on what you have said
If I make a PR against the forked repo so that unecessary dependencies like pycocotools become optional/can be skipped when running setup.py, I think that should solve the issue, but in case they don't accept that change then I'll fork the fork. Is that alright? |
@hmen97 that sounds great! |
Hi @hmen97 did you have any chance to look into this? it this ticket still relevant to you? :) |
Hey @hmen97 We've unassigned you from the issue for now, and moved the issue back to our backlog. If you want to continue your work on it, let me know. |
While working on GPU support for a couple of executors in this issue, I've stumbled over a problem for the Yolov5 segmenter, which can be seem in this draft pr.
CI always fails to install pycocotools on our custom GPU github action runners.
That is fairly annoying, because we dont even need this dependency, it is only introduced because the original upstream authors of yolov5 dont provide a Pypi package and we are using this fork instead. There also have been some related discussions already: here and here
So this issue contains two sub tasks:
The text was updated successfully, but these errors were encountered: