-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU video encoder, rankers and segmenters #169
Comments
I dont think YoloV5Segmenter is actually missing GPU support. It can already be run on GPU, but there is no distinction between cpu/gpu image. We could add it, by forcing CPU version of Pytorch, but I think its not a good idea as it is only an indirect dependency added by YoloV5. As far as I see Yolov5 does not support cpu only |
Why does it not support CPU only? Can you not do |
sure, I mean dependency wise. There is no |
Since we pin our requirements to an exact version, we won't have this problem unless we are changing our requirements intentionally, so I think this is managable. I would still go ahead and create a CPU-only version |
VADSpeechSegmenter can not run on GPU actually. I tried to add support and the inference fails with this message
Also there is pytorch/pytorch#42288 |
I suggest to remove the Yolov5Segenter from the scope of this ticket and close it once the related PRs are merged. |
There are still some GPU-supporting executors missing. This issue finishes the GPU support for the executors.
If there are more executors which are missing GPU support, add them to the list.
Video Encoders:
Segmenters:
VADSpeechSegmenter(not possible)YoloV5Segmenter(postponed)Rankers:
The text was updated successfully, but these errors were encountered: