Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qiqqa: crashes/fails to import PDF from ill-configured servers #63

Closed
GerHobbelt opened this issue Sep 3, 2019 · 1 comment
Closed

Qiqqa: crashes/fails to import PDF from ill-configured servers #63

GerHobbelt opened this issue Sep 3, 2019 · 1 comment
Labels
🐛bug Something isn't working 🦸‍♀️enhancement🦸‍♂️ New feature or request 🕵investigate Needs further analysis to find the root cause.
Milestone
v82

Comments

@GerHobbelt
Copy link
Collaborator

GerHobbelt commented Sep 3, 2019 •
edited

The collected URIs thus far: various issues with each (#54, #56, #31):

Here's the list, copy-pasta from scratchpad:
@GerHobbelt GerHobbelt mentioned this issue Sep 3, 2019
Closed
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Sep 3, 2019
@GerHobbelt
AddNewDocumentToLibraryFromInternet_*() APIs: some nasty/ill-config…
ae42133 
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF.

Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing.

Fixes: jimmejardine#63
@GerHobbelt GerHobbelt changed the title Qiqqa: crashes/fails to import PDF from ill-configured servers ✅Qiqqa: crashes/fails to import PDF from ill-configured servers Sep 3, 2019
@GerHobbelt
Copy link
Collaborator Author

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, pending #15 / any maintainer rights/actions.

@GerHobbelt GerHobbelt mentioned this issue Sep 4, 2019
Closed
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 2, 2019
@GerHobbelt
AddNewDocumentToLibraryFromInternet_*() APIs: some nasty/ill-config…
57037f7 
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF.

Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing.

Fixes: jimmejardine#63
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 3, 2019
@GerHobbelt
AddNewDocumentToLibraryFromInternet_*() APIs: some nasty/ill-config…
0e1538d 
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF.

Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing.

Fixes: jimmejardine#63
@GerHobbelt GerHobbelt added 🐛bug Something isn't working 🦸‍♀️enhancement🦸‍♂️ New feature or request 🤔question Further information is requested or this is a support question labels Oct 4, 2019
@GerHobbelt GerHobbelt added this to the v82 milestone Oct 4, 2019
@GerHobbelt GerHobbelt added 🕵investigate Needs further analysis to find the root cause. and removed 🤔question Further information is requested or this is a support question labels Oct 4, 2019
@GerHobbelt GerHobbelt changed the title ✅Qiqqa: crashes/fails to import PDF from ill-configured servers Qiqqa: crashes/fails to import PDF from ill-configured servers Oct 4, 2019
@GerHobbelt GerHobbelt mentioned this issue Oct 5, 2019
Closed
GerHobbelt added a commit that referenced this issue Nov 5, 2019
@GerHobbelt
AddNewDocumentToLibraryFromInternet_*() APIs: some nasty/ill-config…
3872959 
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF.

Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing.

Fixes: #63
@GerHobbelt GerHobbelt mentioned this issue Dec 10, 2019
Open
@GerHobbelt GerHobbelt mentioned this issue May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug Something isn't working 🦸‍♀️enhancement🦸‍♂️ New feature or request 🕵investigate Needs further analysis to find the root cause.
Projects
None yet
Milestone
v82
Development

No branches or pull requests
1 participant
@GerHobbelt