-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qiqqa: crashes/fails to import PDF from ill-configured servers #63
Labels
🐛bug
Something isn't working
🦸♀️enhancement🦸♂️
New feature or request
🕵investigate
Needs further analysis to find the root cause.
Milestone
Comments
GerHobbelt
added a commit
to GerHobbelt/qiqqa-open-source
that referenced
this issue
Sep 3, 2019
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF. Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing. Fixes: jimmejardine#63
|
GerHobbelt
added a commit
to GerHobbelt/qiqqa-open-source
that referenced
this issue
Oct 2, 2019
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF. Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing. Fixes: jimmejardine#63
GerHobbelt
added a commit
to GerHobbelt/qiqqa-open-source
that referenced
this issue
Oct 3, 2019
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF. Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing. Fixes: jimmejardine#63
GerHobbelt
added a commit
that referenced
this issue
Nov 5, 2019
…ured servers don't produce a legal Content-Type header, or don't provide that header *at all* -- which made Qiqqa barf a hairball instead of properly attempting to import the downloaded PDF. Also don't yak about images which are downloaded as part of Google search pages, etc.: these content-types now make it through *part* of the PDF import code as we cannot rely on the Content-Type header being valid or present, hence we need to be very lenient about what we accept as "potentially a PDF document" to inspect before importing. Fixes: #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛bug
Something isn't working
🦸♀️enhancement🦸♂️
New feature or request
🕵investigate
Needs further analysis to find the root cause.
The collected URIs thus far: various issues with each (#54, #56, #31):
Here's the list, copy-pasta from scratchpad:
http://www.kpubs.org/article/articleDownload.kpubs?downType=pdf&articleANo=E1PWAX_2015_v15n3_644
https://lirias.kuleuven.be/retrieve/533566
http://www.kpubs.org/article/articleDownload.kpubs?downType=pdf&articleANo=E1PWAX_2016_v16n3_905
https://www.mdpi.com/1996-1073/11/1/201/pdf
http://www.kpubs.org/article/articleDownload.kpubs?downType=pdf&articleANo=E1PWAX_2016_v16n3_905
http://www.kpubs.org/article/articleDownload.kpubs?downType=pdf&articleANo=E1PWAX_2015_v15n2_366
http://www.kpubs.org/article/articleDownload.kpubs?downType=pdf&articleANo=E1PWAX_2015_v15n3_577
http://www.koreascience.or.kr/article/ArticleFullRecord.jsp?cn=E1PWAX_2012_v12n5_689
http://library.atmiya.net:8080/dspace/bitstream/handle/123456789/1509/E103871.rar?sequence=1
http://www.dbpia.co.kr/journal/articleDetail?nodeId=NODE00604383
http://scholar.google.com/scholar_url?url=http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.220.2481&rep=rep1&type=pdf&hl=en&sa=T&oi=gga&ct=gga&cd=3&d=1707193501269803852&ei=-ldLXbTHAouOmgHN97PQCQ&scisig=AAGBfm0_iEVOZr1CReSWkPbDAW777Sxr9w&nossl=1&ws=1526x410&at=&bn=1
https://pubs.acs.org/doi/pdf/10.1021/ed1010618?rand=zf7t0csx (no PDF extension, BibTeX Sniffer: PDFs are not downloaded into the Qiqqa library when their URL does not include the "pdf" characters #67)
The text was updated successfully, but these errors were encountered: