-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file not found when using jabref-meta: fileDirectory #349
Comments
After realizing that the issue is introduced somewhere between v80 and v82pre3, I looked at the merged diff between 77469b and 190ff0. The file For the first two cases of the switch, shouldn't we skip the brackets by doing When I tried to change the bibtex line I'd really like to test the fix out, but I'm still unable to compile the code (never actually programmed in c#). I'm going to send a pull request so it's more clear what I meant. I realized we cannot do |
(pullreq mentioned = #350) 👍 Thanks for reporting and the in-depth investigation + pullreq! Apologies for the late reply 🤒 . BibTeX is indeed one of the fickle areas of the Qiqqa codebase; it's been a while since I rooted around in that part but I did have some run-ins with the current Qiqqa BibTeX parser myself -- particularly when handling slightly off-kilter BibTeX files 😓 -- and I've been wondering what the smart thing to do is... Anyway, looks like you've found a bug in my patches, which were intended to make Qiqqa behave when being fed I missed the jabref 👍 Thanks for catching this one; will take a bit to integrate this (due to my limited time ATM) and will be included in the next release. |
I'm running v82.0.7568.29227 (v82pre11).
When importing from a JabRef bibtex file I get a warning dialog saying
The file you selected had xx entries, but xx of them ... the file could not be found on the disk in the location specified by the file entry.
The issue can be reproduced from the following bibtex file
placed in a folder with the following structure:
Interestingly, Qiqqa seems to be ignoring completely the line
@Comment{jabref-meta: fileDirectory:pdfs;}
. If I move the pdf in the same directory as the bib file, even without removing the@Comment
, and even if I put a non-existing folder in it, Qiqqa is able to find the pdf.The same issue also happens with v83.0.7656.6401 and v82pre3. The issue does not happen with v79. EDITED: also not with v80
I tried to look at the source code and found the relevant places this and this. They look perfect to me, so I cannot tell anything's wrong with the code or with my bib file. I tried to compile the code to trace the execution, but unfortunately it seems my build tools are not properly set up.
Appreciates for making Qiqqa❤️ and any help!
The text was updated successfully, but these errors were encountered: