Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sniffer Feature] add options to filter documents list: which are sourced by URL, Local File or not at all (Unsourced) #29

Closed
GerHobbelt opened this issue Aug 7, 2019 · 3 comments
Labels
Milestone

Comments

@GerHobbelt
Copy link
Collaborator

So we can go through the set which has their DownloadLocation set up incorrectly / not at all.

GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Aug 7, 2019
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Aug 7, 2019
- add checkboxes to (sub)select documents which have a URL source registered with them or no source registered at all. (jimmejardine#29)
- add 'invert' logic for the library filter (jimmejardine#30)
@GerHobbelt
Copy link
Collaborator Author

Done as per #33

See also comments at #30 and this commit series:

Revision: 9a7e620
Only when you play with it, you discover what works. The HasSourceURL/Local/Unsourced choices should be OR-ed together as that feels intuitive, while we also want to see 'sans PDF' entries as we can use the Sniffer to dig up the PDF on the IntarWebz if we're lucky. Meanwhile, 'invert' should clearly be positioned off to a corner to signify its purpose: inverting your selection set (while it should probably 🤔 have no effect if a specific document was specified by the user: then we're looking at a particular item PLUS maybe some other stuff?

Revision: 4acc253
Merge branch 'n29'

Revision: 604a5db
Sniffer Features:

Revision: 6283d89
work being done on #29 + #30: augmenting our Jolly Sniffer.

@GerHobbelt GerHobbelt changed the title [Sniffer Feature] add options to filter documents list: which are sourced by URL, Local File or not at all (Unsourced) ✅ [Sniffer Feature] add options to filter documents list: which are sourced by URL, Local File or not at all (Unsourced) Aug 8, 2019
@GerHobbelt
Copy link
Collaborator Author

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, pending #15 / any maintainer rights/actions.

@GerHobbelt
Copy link
Collaborator Author

Related: #27

@GerHobbelt GerHobbelt changed the title ✅ [Sniffer Feature] add options to filter documents list: which are sourced by URL, Local File or not at all (Unsourced) [Sniffer Feature] add options to filter documents list: which are sourced by URL, Local File or not at all (Unsourced) Oct 4, 2019
@GerHobbelt GerHobbelt added the 🦸‍♀️enhancement🦸‍♂️ New feature or request label Oct 4, 2019
@GerHobbelt GerHobbelt added this to the v82 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant