-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associating PDF with Vanilla Reference #253
Comments
IIRC a vanilla ref always stays a vanilla ref: PDFs added to the library are keyed to their content hash and vanilla refs get keyed differently. The work-around for now might be to add the PDF to the library, where it should then show up as a new entry, and then copy the bibtex/annotations over from the Vanilla record to the PDF record. I will have to look into this further when there's more time available; hope the work-around is good enough for you now. |
…df_documents_lock and access_lock interplay via the Associate...() call going directly to the PDFDocument (hence access_lock) while one of the background threads was fetching a list of documents to inspect via Library (hence pdf_documents_lock -> access_lock for each doc): the deadlock occurred because the Associate..() call internally would *add* the new PDF into the Library (hence: pdf_ddocuments_lock inside an access_lock zone, hence DEADLOCK with the bg thread!) Also note that this issue uncovered another matter: PDF association with a Vanilla Reference was not working AT ALL: fixed that as well. (WARNING: association via 'FromWeb' a.k.a. SearchWeb will not deliver AFAICT: only FromLocal associations will deliver. This uncovered yet another bug, which involved the metadata copying code (which still has some TODO's to be addressed at a later time!) resulting in the associated PDF then being marked as a vanilla reference *itself* due to overzealous metadata copying, which includes the 'FileType' field: 'pdf' or 'vanilla_reference'. Fixed as well.
…lls (which return a `bool?` type!) are checked the same way, by explicit comparison against `true`, so `null` and `false` are always treated the same way.
…lls (which return a `bool?` type!) are checked the same way, by explicit comparison against `true`, so `null` and `false` are always treated the same way.
Amazing, thank you so much for your prompt response. Workaround is fine for now! |
Just announced the Qiqqa bugfix release in the qiqqa-releases mailing list
at
qiqqa-releases <qiqqa-releases@googlegroups.com>
To get notified about future releases, you can subscribe to that list:
https://groups.google.com/g/qiqqa-releases?pli=1
Bugfix release can be downloaded at
https://github.com/GerHobbelt/qiqqa-open-source/releases/tag/v82.0.7568-29227
Cheers,
Ger
…On Wed, Oct 21, 2020 at 5:16 PM Wonderkitten ***@***.***> wrote:
Amazing, thank you so much for your prompt response. Workaround is fine
for now!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#253 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCIHXIS3GGE2DQ3CURQOTSL33LPANCNFSM4SYM76AA>
.
|
Whoops, before I forget:
the file association works for **local files** only!
Attempting to associate a PDF "From Web" will fail to produce a
association. This has some deeper issues, which must addressed later as
that's more complex to fix.
Met vriendelijke groeten / Best regards,
Ger Hobbelt
…--------------------------------------------------
web: http://www.hobbelt.com/
http://www.hebbut.net/
mail: ger@hobbelt.com
mobile: +31-6-11 120 978
--------------------------------------------------
On Wed, Oct 21, 2020 at 5:28 PM Ger Hobbelt ***@***.***> wrote:
Just announced the Qiqqa bugfix release in the qiqqa-releases mailing list
at
qiqqa-releases ***@***.***>
To get notified about future releases, you can subscribe to that list:
https://groups.google.com/g/qiqqa-releases?pli=1
Bugfix release can be downloaded at
https://github.com/GerHobbelt/qiqqa-open-source/releases/tag/v82.0.7568-29227
Cheers,
Ger
On Wed, Oct 21, 2020 at 5:16 PM Wonderkitten ***@***.***>
wrote:
> Amazing, thank you so much for your prompt response. Workaround is fine
> for now!
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#253 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADCIHXIS3GGE2DQ3CURQOTSL33LPANCNFSM4SYM76AA>
> .
>
|
Hi,
I'm not having any joy when trying to add a local PDF to a Vanilla Reference in 0.82 on Windows. I get the pop up with a dbl click, get the file browser, choose a file, but then nothing seems to happen with the underlying reference in the library (it remains vanilla, no file associated). Tried multiple files and references, both local libraries and intranet.
The text was updated successfully, but these errors were encountered: