Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same as #17 (unresponsive Qiqqa) but now for large Watch directory sets or RESET Watch Directories #20

Closed
GerHobbelt opened this issue Aug 2, 2019 · 2 comments
Labels
🐛bug Something isn't working ⛷performance Anything that's related to UX: speed of response; I/O speed, etc.
Milestone

Comments

@GerHobbelt
Copy link
Collaborator

Same type of behaviour as #17, either due to dropping a ton of PDFs in the Watch Folder or resetting / changing the Watch Folder, while pointing to a large set of PDFs.

For a 20K+ library, this can take ages and keeps going in the background "almost indefinitely" even after the user closed Qiqqa: this is undesirable behaviour.

The Qiqqa.log logfile gets littered with reams of this stuff:

20190802.180827 INFO [11] FolderWatcher file_system_watcher_Created
20190802.180827 INFO [11] FolderWatcher file_system_watcher_Changed
20190802.180827 INFO [11] FolderWatcher file_system_watcher_Changed
20190802.180827 INFO [11] FolderWatcher file_system_watcher_Created
20190802.180827 INFO [11] FolderWatcher file_system_watcher_Changed
20190802.180827 INFO [11] FolderWatcher file_system_watcher_Changed
20190802.180827 INFO [Main] Waiting for Maintainable Qiqqa.Common.GeneralTaskDaemonStuff.GeneralTaskDaemon:DoMaintenance to terminate.
20190802.180827 INFO [11] FolderWatcher file_system_watcher_Created
20190802.180827 INFO [21] FolderWatcher file_system_watcher_Changed
20190802.180827 INFO [21] FolderWatcher file_system_watcher_Changed

GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Aug 5, 2019
…here is very similar to the code done previously for jimmejardine#17; we just want to add a tiny batch of PDF files from the Watch folder, irrespective of the amount of files waiting there to be added.
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Aug 5, 2019
@GerHobbelt
Copy link
Collaborator Author

Done as per #33.

Commits:

Revision: dc740d7
fix/tweak FolderWatcher background task: make sure we AT LEAST process ONE(1) tiny batch of PDF files when there are any to process.

Revision: 0b7d3b4
fix/tweak: do NOT report 'Adds 0 of 0 document(s)' but clear the status part instead: now that we make Qiqqa work in small batches, this sort of thing MAY happen. (TODO: review WHY the Length of the todo array is actually ZERO, but low priority as things work and don't b0rk)

Revision: da3f853
corrected Folder Watch loop + checks for #20: the intent here is very similar to the code done previously for #17; we just want to add a tiny batch of PDF files from the Watch folder, irrespective of the amount of files waiting there to be added.

Revision: 8a1d766
Fix #17 by processing PDFs in any Qiqqa library in small batches so that Qiqqa is not unreponsive for a loooooooooooooong time when it is re-indexing/upgrading/whatever a large library, e.g. 20K+ PDF files. The key here is to make the 'infrequent background task' produce some result quickly (like a working, yet incomplete, Lucene search index DB!) and then updating/augmenting that result as time goes by. This way, we can recover a search index for larger Qiqqa libraries!

@GerHobbelt
Copy link
Collaborator Author

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, pending #15 / any maintainer rights/actions.

@GerHobbelt GerHobbelt added 🐛bug Something isn't working ⛷performance Anything that's related to UX: speed of response; I/O speed, etc. labels Oct 4, 2019
@GerHobbelt GerHobbelt added this to the v82 milestone Oct 4, 2019
@GerHobbelt GerHobbelt changed the title ✅Same as #17 (unresponsive Qiqqa) but now for large Watch directory sets or RESET Watch Directories Same as #17 (unresponsive Qiqqa) but now for large Watch directory sets or RESET Watch Directories Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working ⛷performance Anything that's related to UX: speed of response; I/O speed, etc.
Projects
None yet
Development

No branches or pull requests

1 participant