Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Copy Another Library" functionality broken #134

Closed
antnazNaz opened this issue Nov 5, 2019 · 10 comments
Closed

"Copy Another Library" functionality broken #134

antnazNaz opened this issue Nov 5, 2019 · 10 comments
Labels
🐛bug Something isn't working
Projects
v82release
Milestone
v82

Comments

@antnazNaz
Copy link

In the process of converting my v79 to v82pre4, old web libraries are functioning well and are locally stored. When creating a new intranet library, copying from other libraries does not do anything - nothing gets transferred, no messages.
@antnazNaz
Copy link
Author

Going into the original library and copying item-by-item also doesn't copy those records to the destination intranet library.

@GerHobbelt GerHobbelt added the 🐛bug Something isn't working label Nov 5, 2019
@GerHobbelt GerHobbelt added this to the v82 milestone Nov 5, 2019
@GerHobbelt GerHobbelt added the 🤔question Further information is requested or this is a support question label Nov 5, 2019
@GerHobbelt
Copy link
Collaborator

Are you copying documents from one library to another via selecting them and then in right-click menu choosing 'Copy to another library' or did you do this another way?

Thanks for filing, BTW. 👍

@antnazNaz
Copy link
Author

I tried both ways and neither of those options worked. Moving also didn't work. I thought maybe it was due to an issue with a legacy web library so I tried to copy a fresh pdf between two newly created intranet (dropbox) libraries. It didn't work...

Also... glad you're so committed to Qiqqa - it's a great tool and I do my best to get others to use it instead of subpar alternatives like M#@$lay or Z##$#$ro

@antnazNaz
Copy link
Author

I also went through the effort to uninstall and reinstall Qiqqa pre5, while deleting the AppData folder. Issue remains.

@antnazNaz
Copy link
Author

Well, good news - it works with 82pre3 but not pre4 or pre5. So there's a regression bug somewhere in pre4 code.

@GerHobbelt
Copy link
Collaborator

🤔 🤔 That's nasty. Hadn't expected that regression. I wonder why it happened. 🤔 Thanks for testing the versions, by the way.

It may take a few days and I may pester you for a couple of screenshots or directory dumps if you're available for testing then (dev effort fluctuates per day, depending on RL priorities; tomorrow is expected to be a busy day, so less time to dig into this)

Anyway, if I create a new prerelease to test this, I'll signal you via this issue, so you can test any changes I make. Testing those would be highly appreciated.

And thanks for the thumbs up, indeed Zotero et al didn't fly for me either. Though I must say that the last year with v79 was an enormous pain as my search index broke down and I couldn't get it back up until Qiqqa went Open Source - another project of mine on github shows the reverse engineering process and data-dumping I did before that time as I needed the Qiqqa Sniffer and an external search engine to make it work for me. 😱 Oh, the fun. [/rant]

@antnazNaz
Copy link
Author

Happy to assist any way I can 👍

@GerHobbelt GerHobbelt added this to To do in v82release Nov 6, 2019
@GerHobbelt GerHobbelt moved this from To do to In progress in v82release Nov 7, 2019
@GerHobbelt
Copy link
Collaborator

Did a test with bleeding edge code: I can confirm the bug. 👍

@GerHobbelt GerHobbelt removed the 🤔question Further information is requested or this is a support question label Nov 9, 2019
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Nov 9, 2019
@GerHobbelt
- fixing jimmejardine#134 : Copy/Move to library functionality was b0…
f4791a0 
…rked due to crufty coding of passing the return value (picked library) while I had been a tad overzealous when going through the code hunting down memleak spots, i.e. Dispose and Close handlers' cleanup, resulting in the library picker dialog always producing a NULL library reference.

- Also tweaked the copy/move process a little while testing the copy & move actions.

- Migrated the copy/merge activity to a background task to ensure a more responsive UI, particularly when copying/moving large numbers of PDFDocuments at once!

TODO: proper collision detection and merge action on the metadata when you import Documents which are already present in the library, but might need to have their metadata (partially!) updated. Currently the existing metadata is largely nuked. Check out AddNewDocumentToLibrary() in Library.cs and the TODO comments in Library.cs and PDFDocument.cs when you're working on the MERGE METADATA job.
@GerHobbelt
Copy link
Collaborator

@antnazNaz : there's a new v82pre6 prerelease installer available at https://github.com/GerHobbelt/qiqqa-open-source/releases/tag/v82.0.7222.1299 which should fix this copy/move documents issue.

Much appreciated if you could test-fly that one and see if the problem is truly resolved. 😁

@GerHobbelt GerHobbelt moved this from In progress to Done in v82release Nov 10, 2019
@antnazNaz
Copy link
Author

Works well! Thanks

@GerHobbelt GerHobbelt mentioned this issue Oct 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug Something isn't working
Projects
v82release
  
Done
Milestone
v82
Development

No branches or pull requests
2 participants
@GerHobbelt @antnazNaz