Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on #37: code cleanup #118

Closed
GerHobbelt opened this issue Oct 19, 2019 · 1 comment
Closed

Follow-up on #37: code cleanup #118

GerHobbelt opened this issue Oct 19, 2019 · 1 comment
Labels
🕵code review When the issue popped up due to code review or when (larger) code review is required. 🕵investigate Needs further analysis to find the root cause.
Projects
Milestone

Comments

@GerHobbelt
Copy link
Collaborator

See initial report in #37 :


DevTip: Also do global search for QiqqaOCR and pdfdraw as there are such beauties as these lingering in the codebase:

485: int SECONDS_TO_WAIT = 60; // MAKE SURE THIS NUMBER IS LARGER THAN THE NUMBER IN THE ACTUAL QiqqaOCR so that QiqqaOCR has time to finish up...!
525: int SECONDS_TO_WAIT = 210; // MAKE SURE THIS NUMBER IS LARGER THAN THE NUMBER IN THE ACTUAL QiqqaOCR so that QiqqaOCR has time to finish up...!
90: // Support windows-level error reporting - helps suppressing the errors in pdfdraw.exe and QiqqaOCR.exe
91 // https://msdn.microsoft.com/en-us/library/windows/desktop/ms680621%28v=vs.85%29.aspx


As suggested in last comment there: remove the redundancy in the code by sending the timeout setting from Qiqqa to QiqqaOCR via ARGV.

@GerHobbelt GerHobbelt added 🕵investigate Needs further analysis to find the root cause. 🕵code review When the issue popped up due to code review or when (larger) code review is required. labels Oct 19, 2019
@GerHobbelt GerHobbelt added this to the Our Glorious Future milestone Oct 19, 2019
@GerHobbelt GerHobbelt modified the milestones: Our Glorious Future, v82 Nov 5, 2019
@GerHobbelt GerHobbelt added this to In progress in v82release Nov 5, 2019
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Nov 5, 2019
…rgument), but as Utilities constant. Still a bit hacky to my tastes, but this should work and keep working. Timeout has been adjusted slightly upwards too to compensate for heavily loaded and/or slow machines: OCR'ing a page should take less than 4 minutes...
@GerHobbelt GerHobbelt moved this from In progress to Done in v82release Nov 6, 2019
@GerHobbelt
Copy link
Collaborator Author

See referenced commit above. Fixed. Bit hacky, but slightly better than what was, IMO. Timeout shouldn't be hardcoded anyway and more watchdog-like driven by QiqqaOCR activity, but that's for another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵code review When the issue popped up due to code review or when (larger) code review is required. 🕵investigate Needs further analysis to find the root cause.
Projects
v82release
  
Done
Development

No branches or pull requests

1 participant