Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: apply AlphaFS everywhere in Qiqqa so that we support long filenames, etc. consistently #106

Closed
GerHobbelt opened this issue Oct 15, 2019 · 1 comment
Closed

Refactor: apply AlphaFS everywhere in Qiqqa so that we support long filenames, etc. consistently #106

GerHobbelt opened this issue Oct 15, 2019 · 1 comment
Labels
🕵code review When the issue popped up due to code review or when (larger) code review is required. 🦸‍♀️enhancement🦸‍♂️ New feature or request
Milestone
v82

Comments

@GerHobbelt
Copy link
Collaborator

See featureset of AlphaFS: https://github.com/alphaleonis/AlphaFS
@GerHobbelt GerHobbelt added 🦸‍♀️enhancement🦸‍♂️ New feature or request 🕵code review When the issue popped up due to code review or when (larger) code review is required. labels Oct 15, 2019
@GerHobbelt GerHobbelt added this to the v83 milestone Oct 15, 2019
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 15, 2019
@GerHobbelt
belated commit fixing code typo due to AlphaFS upgrade/refactoring in…
4c92fee 
… commit SHA-1: 7ecf0ae and jimmejardine#106
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 15, 2019
@GerHobbelt
cf. SHA-1: 4c92fee * belated commit fixing code typo due to AlphaFS u…
d6f173d 
…pgrade/refactoring in commit SHA-1: 7ecf0ae and jimmejardine#106
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 15, 2019
@GerHobbelt
- refactoring the PDFDocument code and making its interface threadsaf…
6ef9b44 
…e (apart from the inks, annotations and highlights attribute lists). Fixes jimmejardine#96.

- improve the internal code of `CloneExistingDocumentFromOtherLibrary_SYNCHRONOUS()` to help ensure we will be able to copy/transfer all metadata from the sourcing document to the clone. Code simplification.
- code simplification/performance: remove useless LINQ overhead
- `SignalThatDocumentsHaveChanged()`: improve code by making sure that a reference PDF is only provided when there really is only a single PDF signaled! Also see the spots where this API is being used.
- belated commit of AlphaFS upgrade/refactoring for jimmejardine#106 ; a multi-pass code review has been applied to uncover all places where (file/directory) paths are manipulated/processed in the Qiqqa code. TODO: Streams.
- redesign the ADD/REMOVE/GET-password APIs for PDFDocument as the indirection in the Qiqqa made it bloody hard to make thread-safe otherwise. (Fixes jimmejardine#96 / jimmejardine#98)
- ditto for the GC-memleaking bindables of PDFDocument: all the binding stuff has been moved to the PDFDocument thread-safe wrapper class. (TODO: investigate if we can use WeakReferences more/better to prevent memleaks due to infinitely marked PDFDocument instances...)
- tweak: `AddLegacyWebLibrariesThatCanBeFoundOnDisk()`: at startup, try to load all .known_web_libraries files you can find as those should provide better (= original) names of the various Commercial Qiqqa Web Libraries. (This is running ahead to the tune of jimmejardine#109 / jimmejardine#103)
@GerHobbelt
Copy link
Collaborator Author

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, i.e. v82pre3 experimental release and beyond.

GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 19, 2019
@GerHobbelt
a fix for one path we didn't get for jimmejardine#106 + be more stric…
761b192 
…t in checking whether a Web Library sync directory has been properly set up.
@GerHobbelt GerHobbelt modified the milestones: v83, v82 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕵code review When the issue popped up due to code review or when (larger) code review is required. 🦸‍♀️enhancement🦸‍♂️ New feature or request
Projects
None yet
Milestone
v82
Development

No branches or pull requests
1 participant
@GerHobbelt