jgrss/v170 issues #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* format * remove attr * add grid attr check * pin upper lightning * change * change * format * docs: Update README.md (#62) minor update to install of pyenv * make the default resolution None * fix the bounds setting --------- Co-authored-by: Michael Mann <mmann1123@gmail.com>
nnguyen622
reviewed
May 4, 2023
Comment on lines
+52
to
+57
| if rechunk: | ||
| src = src.chunk( | ||
| chunks={ | ||
| 'band': -1, | ||
| 'y': new_row_chunks, | ||
| 'x': new_col_chunks, |
There was a problem hiding this comment.
oh nice! This adds another check when running inference on small images 👍
nnguyen622
reviewed
May 4, 2023
Comment on lines
-277
to
+278
| ref_res: T.Optional[float] = 10.0, | ||
| ref_res: T.Optional[T.Union[float, T.Tuple[float, float]]] = 10.0, |
There was a problem hiding this comment.
so here you also accept tuples of values?
There was a problem hiding this comment.
@nnguyen622 the default cell size is now None (see the commit in args.yml). This change allows the resolution to be gathered from the image (e.g., in case the user doesn't know the exact cell size). If taken from the image, and in cases of non-square pixels, tuples are allowed.
jgrss
commented
May 4, 2023
| @@ -85,7 +85,7 @@ shared_create: | |||
| long: res | |||
| help: The cell resolution | |||
| kwargs: | |||
| default: 10.0 | |||
| default: !!null | |||
There was a problem hiding this comment.
If the default here is unchanged by the user, the cell resolution will be taken directly from the image.
jgrss
commented
May 4, 2023
| @@ -739,7 +739,14 @@ def create_datasets(args): | |||
| ) | |||
|
|
|||
| total_iters = len( | |||
| list(itertools.product(inputs.year_lists, inputs.regions_lists)) | |||
| list( | |||
There was a problem hiding this comment.
This chunk fixes the broken progress bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR #64: