-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlipAxis fix #57
FlipAxis fix #57
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This reverts commit cecdb0c.
Just in case this is useful for someone: I had to revert these changes in my local copy, since they lower my models accuracy and confidence significantly. Not sure why, though. |
Hmm... I briefly looked back at the changes I made and the errors people are experiencing have to be a result of the change from methods _augment_images and _augment_keypoints to _augment_batch_, which is the preferred way of making custom augmenters now apparently, see this. Perhaps it's incompatible with an older version of imgaug (before 0.4.0). @eduramiba what version are you using? It'll be an easy fix to separate augment_batch back into the two methods, if that's the issue. |
Hi @iuls I tried this with imgaug 0.4.0 |
Interesting... so are you getting a different error than this? |
I am not getting any error, just worse results, always reproducible. Thanks |
I honestly don't remember since I was using this repo a while ago now, but I thought I was getting similar results. You probably already tried this, but I wonder if you use the augmenter to flip some images and plot the keypoints, do you see any discrepancies there? |
Hi, In my training script, I visualize some images before the training starts so I can check that things look right and keypoints are well placed, and they do look right with both versions. That's the strange thing.... So maybe it works the same for most cases but not some edge cases. |
That's weird... In terms of transforming the actual keypoint locations I don't think I made any changes to the old code. This change was just supposed to provide support for both left-right and up-down flips in one class. I'll investigate some more! |
Thanks! If it helps, I am doing this:
|
This change seems to work for me! I've also tried it with the TrainingGenerator and it works fine. Right now only the images and keypoints are being transformed, whereas the augmenters Flipud/Fliplr also transform bounding boxes/heatmaps/etc. If that's necessary, one can easily add it using the same format as here.