Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports for Tensorflow 2.1.0 #39

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Fix imports for Tensorflow 2.1.0 #39

merged 1 commit into from
Feb 23, 2020

Conversation

eduramiba
Copy link
Contributor

No description provided.

@stale
Copy link

stale bot commented Jan 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue has been inactive for 7 days label Jan 18, 2020
@jgraving jgraving added the enhancement New feature or request label Jan 23, 2020
@stale stale bot removed the stale Issue has been inactive for 7 days label Jan 23, 2020
@jgraving
Copy link
Owner

Thanks. I'll take a look when I get a bit of free time. Does this break compatibility with earlier versions?

@jgraving jgraving added bug Something isn't working tensorflow An issue with Tensorflow and removed enhancement New feature or request labels Jan 23, 2020
@eduramiba
Copy link
Contributor Author

Unfortunately I am not sure whether it works with tensorflow 2.0 and 1.15 but I will test it as soon as possible. Maybe it's possible to change imports dynamically depending on the tensorflow version.

@jgraving jgraving merged commit b3bb539 into jgraving:master Feb 23, 2020
@lambdaloop
Copy link

This does seem to break compatibility with tensorflow 1.12. Downgrading to 0.3.5 (before this pull request) seems to fix this.

It would be nice to have the imports change dynamically.

@jgraving
Copy link
Owner

jgraving commented Apr 6, 2020

Ok. Thanks for the update. I'll look into this when I get a chance. Hopefully just a matter of switching the imports to tf.compat.v2

@jgraving jgraving mentioned this pull request Apr 9, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working tensorflow An issue with Tensorflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduramiba @jgraving @lambdaloop