Replace maven_jar by maven_install from rules_jvm_external #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisd
added a commit
to regisd/jflex
that referenced
this pull request
Mar 9, 2020
This is needed as v7 was using the deprecated native.maven_jar See jflex-de/bazel_rules#21
regisd
added a commit
to jflex-de/jflex
that referenced
this pull request
Mar 16, 2020
* Upgrade Bazel version in Cirrus to 2.1.0 * Update jflex() bazel rule to v8 This is needed as v7 was using the deprecated native.maven_jar See jflex-de/bazel_rules#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native
maven_jarrule has been deprecated in bazel 1.2.0 https://docs.bazel.build/versions/1.2.0/be/workspace.html#maven_jar and removed in bazel 2.0.0