ensure callback is always completed in WebSocketCoreSession #11309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lorban
approved these changes
Jan 24, 2024
sbordet
approved these changes
Jan 25, 2024
lachlan-roberts
deleted the
jetty-12.0.x-ensureCallbackComplete-WebSocketCoreSession
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the session is already closed the callback for
WebSocketCoreSession.processHandlerErrorandWebSocketCoreSession.processConnectionError.Almost always when this method is called is with a
NOOPcallback.There is one spot which uses the frame callback, which is why we don't want to fail the callback here because the frame callback on failure will call back
processHandlerError.